Michael Pasternak has posted comments on this change. Change subject: cli: ovirt-shell does not exit when using -f option(#854519) ......................................................................
Patch Set 1: (3 inline comments) ravi, well done!, the thing is that shell currently writes only to own private I/O stream, so by implementing this RFE entier script output will be swallowed, lets postpone this BZ till #895559 got implemented .................................................... Commit Message Line 4: Commit: Ravi Nori <rn...@redhat.com> Line 5: CommitDate: 2013-02-19 11:05:39 -0500 Line 6: Line 7: cli: ovirt-shell does not exit when using -f option(#854519) Line 8: link to BZ? Line 9: ovirt-shell does not exit when -f option is used. This option Line 10: is used by system scripts and it would be useful to exit the Line 11: ovirt-shell upon completion of the command execution. Line 12: .................................................... File src/ovirtcli/shell/engineshell.py Line 266: self.emptyline(no_prompt=True) Line 267: return True Line 268: Line 269: def exitWithStatusAndMsg(self, status=0, msg=None): Line 270: if msg: print (msg + '\n') you have self.print_line() for this Line 271: sys.exit(status) Line 272: Line 273: def do_exit(self, args): Line 274: """\ Line 267: return True Line 268: Line 269: def exitWithStatusAndMsg(self, status=0, msg=None): Line 270: if msg: print (msg + '\n') Line 271: sys.exit(status) because shell writes only to own private I/O stream, this message will be swallowed among with script output btw. Line 272: Line 273: def do_exit(self, args): Line 274: """\ Line 275: == Usage == -- To view, visit http://gerrit.ovirt.org/12212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5441a401ed39fc7148b6001fb826b145ba66d6c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
