[Engine-patches] Change in ovirt-engine[master]: engine: fix locking issue in GlusterMultipleActionsRunner

2013-01-31 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: fix locking issue in GlusterMultipleActionsRunner .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11597 To unsubscribe, visit http://

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3409 - Still Failing!

2013-01-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3409/ Build Number: 3409 Build Status: Still Failing Triggered By: Started by upstream project "ovirt_engine" build number 4,172 - Changes

[Engine-patches] Change in ovirt-engine[master]: engine: fix locking issue in GlusterMultipleActionsRunner

2013-01-31 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: fix locking issue in GlusterMultipleActionsRunner .. Patch Set 1: (1 inline comment) Thanks, new patch-set to follow. .

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed a spelling mistake in AuditLogAgingThreashold ...

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold config var .. Patch Set 3: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2013-01-31 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: core: Make dependency on commons-collections explicit .. core: Make dependency on commons-collections explicit The code imports classes from the org.ap

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2013-01-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous approval. -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2013-01-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit .. Patch Set 1: No, I just don't usually like to merge changes outside of the "packaging" area myself, I

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show clusters with Virt service enabled only for V...

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: webadmin: Show clusters with Virt service enabled only for VM .. Patch Set 2: (3 inline comments) File backend/

[Engine-patches] Change in ovirt-engine[master]: pki: process template files not in-place

2013-01-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: pki: process template files not in-place .. Patch Set 2: (1 inline comment) File packaging/fedora/spec/ovir

[Engine-patches] Change in ovirt-engine[master]: engine: Making increase of storage pool master domain versio...

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: Making increase of storage pool master domain version atomic operation .. Patch Set 2: (2 inline comments)

[Engine-patches] Change in ovirt-engine[master]: packaging: allow interactive NFS exports cleanup with engine...

2013-01-31 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: allow interactive NFS exports cleanup with engine-cleanup .. Patch Set 3: No score (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: tools, backend: better error logging for notifierd

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: tools, backend: better error logging for notifierd .. Patch Set 2: (3 inline comments) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: notifier: resource leak using all available db connections

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: notifier: resource leak using all available db connections .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: db: support absolute log files

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: db: support absolute log files .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11571 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: db: do not override log file

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: db: do not override log file .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11572 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: db: do not override ENGINE_PGPASS if exists

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: db: do not override ENGINE_PGPASS if exists .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11574 To unsub

[Engine-patches] Change in ovirt-engine[master]: db: make backup.sh respenct ENGINE_PGPASS

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: db: make backup.sh respenct ENGINE_PGPASS .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11575 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: db: allow execution from other directories

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: db: allow execution from other directories .. Patch Set 1: (1 inline comment) File backend/manager/dbscripts/up

[Engine-patches] Change in ovirt-engine[master]: engine: Removing harmfull code from persitance of task to DB

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: Removing harmfull code from persitance of task to DB .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11591 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: restapi: Rest API for brick advanced details

2013-01-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: restapi: Rest API for brick advanced details .. Patch Set 2: (1 inline comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: restapi: Rest API for brick advanced details

2013-01-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: restapi: Rest API for brick advanced details .. Patch Set 2: (1 inline comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show clusters with Virt service enabled only for V...

2013-01-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: Show clusters with Virt service enabled only for VM .. Patch Set 2: If we can make the filtering more generic like fetching the DataCenters/Clusters bas

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper from utils package

2013-01-31 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Remove StringHelper from utils package .. Patch Set 1: (2 inline comments) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper from utils package

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove StringHelper from utils package .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11609 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-live[master]: packaging: initial repo creation

2013-01-31 Thread mgoldboi
Moran Goldboim has submitted this change and it was merged. Change subject: packaging: initial repo creation .. packaging: initial repo creation oVirt Live is an unofficial spin of live fedora 17(currently), based on oVirt 3.1

[Engine-patches] Change in ovirt-live[master]: packaging: initial repo creation

2013-01-31 Thread mgoldboi
Moran Goldboim has posted comments on this change. Change subject: packaging: initial repo creation .. Patch Set 21: Looks good to me, approved I would like to push this working initial repo creation, and continue improving re

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper from vdsbroker package

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove StringHelper from vdsbroker package .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11608 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper from vdsbroker package

2013-01-31 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove StringHelper from vdsbroker package .. core: Remove StringHelper from vdsbroker package Remove the last leftovers of the deprecated StringHelper u

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper from utils package

2013-01-31 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove StringHelper from utils package .. core: Remove StringHelper from utils package Remove the last leftovers of the deprecated StringHelper usages fr

[Engine-patches] Change in ovirt-live[master]: packaging: initial repo creation

2013-01-31 Thread obasan
Ohad Basan has posted comments on this change. Change subject: packaging: initial repo creation .. Patch Set 21: Verified -- To view, visit http://gerrit.ovirt.org/9733 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit .. Patch Set 1: Verified; Looks good to me, approved verified build with maven 3.0.4 on RHEL 6.3 @Juan -

[Engine-patches] Change in ovirt-engine[master]: core: RemoveStorageDomainTest: simply msg checking

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: RemoveStorageDomainTest: simply msg checking .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11607 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: RemoveStorageDomainTest: simply msg checking

2013-01-31 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: RemoveStorageDomainTest: simply msg checking .. core: RemoveStorageDomainTest: simply msg checking Simplified the way canDoAction messages are asserted i

[Engine-patches] Change in ovirt-engine[master]: core: Remove AuditLogableBaseMockUtils

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove AuditLogableBaseMockUtils .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11606 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Remove AuditLogableBaseMockUtils

2013-01-31 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove AuditLogableBaseMockUtils .. core: Remove AuditLogableBaseMockUtils AuditLogableBaseMockUtils was used to mock VmDAO in tests for bll commands. si

[Engine-patches] Change in ovirt-engine[master]: packaging: allow interactive NFS exports cleanup with engine...

2013-01-31 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: allow interactive NFS exports cleanup with engine-cleanup .. Patch Set 3: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: packaging: allow importing existing ISO domain on setup

2013-01-31 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: allow importing existing ISO domain on setup .. Patch Set 2: (2 inline comments) File packaging/fed

[Engine-patches] Change in ovirt-engine[master]: webadmin: create cluster hangs

2013-01-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: create cluster hangs .. Patch Set 1: (2 inline comments) File frontend/webadmin/modules/uicommonweb

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: add more verbose debug

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: hardware: add more verbose debug .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11604 To unsubscribe, visit

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: add more verbose debug

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: hardware: add more verbose debug .. vdsm: hardware: add more verbose debug Change-Id: Ie4449d076713e47e947e1c0060616e4e5d334e85 Signed-off-by: Alon

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: add more verbose debug

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: vdsm: hardware: add more verbose debug .. vdsm: hardware: add more verbose debug Change-Id: Ie4449d076713e47e947e1c0060616e4e5d334e85 Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: add more verbose debug

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: hardware: add more verbose debug .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11603 To unsubscribe, visit

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: add more verbose debug

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: hardware: add more verbose debug .. vdsm: hardware: add more verbose debug Change-Id: I2605bd9f51fed3be14e475c8555428d5accbc957 Signed-off-by: Alon

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: use constants for cpu names

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: hardware: use constants for cpu names .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11602 To unsubscribe, v

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: use constants for cpu names

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: hardware: use constants for cpu names .. vdsm: hardware: use constants for cpu names Change-Id: Id5eb59081051e4b205570255046c3aae21fa3aac Signed-of

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Show warning for non-exportable disks

2013-01-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal, webadmin: Show warning for non-exportable disks .. Patch Set 3: (3 inline comments) File frontend

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: add more verbose debug

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: hardware: add more verbose debug .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11603 To unsubscribe, visit

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: use constants for cpu names

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: hardware: use constants for cpu names .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11602 To unsubscribe, v

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: add more verbose debug

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: vdsm: hardware: add more verbose debug .. vdsm: hardware: add more verbose debug Change-Id: I2605bd9f51fed3be14e475c8555428d5accbc957 Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: hardware: use constants for cpu names

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: vdsm: hardware: use constants for cpu names .. vdsm: hardware: use constants for cpu names Change-Id: Id5eb59081051e4b205570255046c3aae21fa3aac Signed-off-by: Al

[Engine-patches] Change in ovirt-engine[master]: pki: process template files not in-place

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: process template files not in-place .. Patch Set 2: (1 inline comment) File packaging/fedora/spec/ovirt-

[Engine-patches] Change in ovirt-engine[master]: core: Removal of DNS root from host name

2013-01-31 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: Removal of DNS root from host name .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11601 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: core: Removal of DNS root from host name

2013-01-31 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: core: Removal of DNS root from host name .. core: Removal of DNS root from host name This fix removes the DNS root name from the host name. The DNS root name appear

[Engine-patches] Change in ovirt-engine[master]: core: Remove storage domain space checker

2013-01-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Remove storage domain space checker .. Patch Set 1: Sure, I agree this is in progress. -- To view, visit http://gerrit.ovirt.org/11589 To unsubscribe, visi

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 2833 - Fixed!

2013-01-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2833/ Build Number: 2833 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when validating move or copy.

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator when validating move or copy. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11513 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Add storage space validator

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Add storage space validator .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11511 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core:(WIP) Use storage validator when adding a new VM

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core:(WIP) Use storage validator when adding a new VM .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11512 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: ImportVmCommand - added method getUpdatedVmForOperatio...

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation() .. Patch Set 16: Looks good to me, approved Liron, this patch fails to rebase. Please rebase, s

[Engine-patches] Change in ovirt-engine[master]: core, ui: test duplicate keys in appErrors

2013-01-31 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core,ui: test duplicate keys in appErrors .. core,ui: test duplicate keys in appErrors The tests introduced in this patch check if AppErrors.properties

[Engine-patches] Change in ovirt-engine[master]: core, ui: test duplicate keys in appErrors

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core,ui: test duplicate keys in appErrors .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11343 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: ImagesHandler: Remove SD status validation

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ImagesHandler: Remove SD status validation .. Patch Set 4: Verified Added javadoc as per Alissa's comment -- To view, visit http://gerrit.ovirt.org/11487

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 2832 - Failure!

2013-01-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2832/ Build Number: 2832 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: engine: fix locking issue in GlusterMultipleActionsRunner

2013-01-31 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: fix locking issue in GlusterMultipleActionsRunner .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: packaging: substitute engineVersion.js in target that actual...

2013-01-31 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: substitute engineVersion.js in target that actually create it .. packaging: substitute engineVersion.js in target that actually create it C

[Engine-patches] Change in ovirt-engine[master]: packaging: substitute engineVersion.js in target that actual...

2013-01-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: substitute engineVersion.js in target that actually create it .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: pki: process template files not in-place

2013-01-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: pki: process template files not in-place .. Patch Set 2: (1 inline comment) File packaging/fedora/spec/ovir

[Engine-patches] Change in ovirt-engine[master]: packaging: set both PGPASSFILE and ENGINE_PGPASS

2013-01-31 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: set both PGPASSFILE and ENGINE_PGPASS .. packaging: set both PGPASSFILE and ENGINE_PGPASS This will enable us to drop modifying defaults for

[Engine-patches] Change in ovirt-engine[master]: compat: convert to base64 without line feed

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: compat: convert to base64 without line feed .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11596 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: packaging: set both PGPASSFILE and ENGINE_PGPASS

2013-01-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: set both PGPASSFILE and ENGINE_PGPASS .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11573 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: pki: encryptpasswd: remove unneeded pushd/popd

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: encryptpasswd: remove unneeded pushd/popd .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11580 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: packaging: set both PGPASSFILE and ENGINE_PGPASS

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: set both PGPASSFILE and ENGINE_PGPASS .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11573 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: packaging: substitute engineVersion.js in target that actual...

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: substitute engineVersion.js in target that actually create it .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11579 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: pki: install private directories not world readable

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: install private directories not world readable .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11578 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: pki: process template files not in-place

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: process template files not in-place .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11577 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: webadmin: replace 'VM' with 'Virtual Machine'

2013-01-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: replace 'VM' with 'Virtual Machine' .. webadmin: replace 'VM' with 'Virtual Machine' Replace 'VM' term with 'Virtual Machine' in newly added st

[Engine-patches] Change in ovirt-engine[master]: webadmin: replace 'VM' with 'Virtual Machine'

2013-01-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: replace 'VM' with 'Virtual Machine' .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11563 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: packaging: set both PGPASSFILE and ENGINE_PGPASS

2013-01-31 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: set both PGPASSFILE and ENGINE_PGPASS .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11573 To

[Engine-patches] Change in ovirt-engine[master]: webadmin: replace 'VM' with 'Virtual Machine'

2013-01-31 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: replace 'VM' with 'Virtual Machine' .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11563 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: db: do not override ENGINE_PGPASS if exists

2013-01-31 Thread alourie
Alex Lourie has posted comments on this change. Change subject: db: do not override ENGINE_PGPASS if exists .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11574 To unsu

[Engine-patches] Change in ovirt-engine[master]: compat: convert to base64 without line feed

2013-01-31 Thread fkobzik
Frank Kobzik has restored this change. Change subject: compat: convert to base64 without line feed .. Patch Set 2: Restored Accidentally abandoned - restoring. -- To view, visit http://gerrit.ovirt.org/11596 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core:(WIP) VM pool snapshot should not be stateless.

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core:(WIP) VM pool snapshot should not be stateless. .. Patch Set 1: @Maor - any news about this patch? we want to move forward and close this bug -- To view,

[Engine-patches] Change in ovirt-engine[master]: compat: convert to base64 without line feed

2013-01-31 Thread fkobzik
Frank Kobzik has abandoned this change. Change subject: compat: convert to base64 without line feed .. Patch Set 2: Abandoned Fixed in Change-Id I33790b47ede99eade178b488a66cd8cc280cb872 -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: compat: convert to base64 without line feed

2013-01-31 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: compat: convert to base64 without line feed .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11596 To uns

[Engine-patches] Change in ovirt-engine[master]: compat: convert to base64 without line feed

2013-01-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: compat: convert to base64 without line feed .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11596 To u

[Engine-patches] Change in ovirt-engine[master]: core: prevent changing display settings when vm isn't down

2013-01-31 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: prevent changing display settings when vm isn't down .. core: prevent changing display settings when vm isn't down This patch adds display protocol

[Engine-patches] Change in ovirt-engine[master]: core: prevent changing display settings when vm isn't down

2013-01-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: prevent changing display settings when vm isn't down .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11537 To

[Engine-patches] Change in ovirt-engine[master]: compat: convert to base64 without line feed

2013-01-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: compat: convert to base64 without line feed .. Patch Set 2: Hello Frank, What do you think about this one? Alon -- To view, visit http://gerrit.ovirt.org/11596

[Engine-patches] Change in ovirt-engine[master]: notifier: resource leak using all available db connections

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: notifier: resource leak using all available db connections .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: engine: Clean up of RecoveryStoragePoolCommand

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Clean up of RecoveryStoragePoolCommand .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11203 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: Complete removal of Hibernate

2013-01-31 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: packaging: Complete removal of Hibernate .. packaging: Complete removal of Hibernate Recently we have removed dead Hibernate code, this requires some p

[Engine-patches] Change in ovirt-engine[master]: packaging: Complete removal of Hibernate

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: packaging: Complete removal of Hibernate .. Patch Set 2: Verified; Looks good to me, approved Rebased, no changes. Verified also by Juan. -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: cleanup Handler classes

2013-01-31 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup Handler classes .. core: cleanup Handler classes Change the visibility of ObjectIdentityChecker instance in VmHandler, VdsHander and VmTemp

[Engine-patches] Change in ovirt-engine[master]: core: cleanup Handler classes

2013-01-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: cleanup Handler classes .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11536 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: cleanup Handler classes

2013-01-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: cleanup Handler classes .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11536 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: restapi: Add support for tunnel migration

2013-01-31 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: restapi: Add support for tunnel migration .. restapi: Add support for tunnel migration add tunnel migration field to cluster and vm Change-Id: I2822082c

[Engine-patches] Change in ovirt-engine[master]: restapi: Add support for tunnel migration

2013-01-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: restapi: Add support for tunnel migration .. Patch Set 5: Verified; Looks good to me, approved just rebased, ack by mpasternak -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core, ui: test duplicate keys in appErrors

2013-01-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core,ui: test duplicate keys in appErrors .. Patch Set 6: Verified; Looks good to me, approved Rebased, no code changes. Verified by Alissa. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: core: add support for tunnel migration

2013-01-31 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: add support for tunnel migration .. core: add support for tunnel migration with 'tunnel migration' the migration process is using libvirt-to-libvir

[Engine-patches] Change in ovirt-engine[master]: core: add support for tunnel migration

2013-01-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: add support for tunnel migration .. Patch Set 8: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11062 To unsubscribe, visit

  1   2   >