Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: Show warning for non-exportable disks
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java
Line 193: if (message == null) {
Line 194: return;
Line 195: }
Line 196:
Line 197: messagePanel.add(new
HTML(StringUtils.addHtmlLineBreaks(message)));
Why adding a new HTML instead of a new Label?
('addHtmlLineBreaks' method usage could be prevented that way)
Line 198: }
Line 199:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
Line 83: if (message == null) {
Line 84: return;
Line 85: }
Line 86:
Line 87: messagePanel.add(new
HTML(StringUtils.addHtmlLineBreaks(message)));
same here
Line 88: }
Line 89:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmExportPopupView.java
Line 66: if (message == null) {
Line 67: return;
Line 68: }
Line 69:
Line 70: messagePanel.add(new
HTML(StringUtils.addHtmlLineBreaks(message)));
same here
Line 71: }
Line 72:
Line 73: @Override
Line 74: public void edit(ExportVmModel object) {
--
To view, visit http://gerrit.ovirt.org/11144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a183931e36ccd4668225ad206edc4a5e58795e3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
