Eli Mesika has posted comments on this change.
Change subject: engine: Making increase of storage pool master domain version
atomic operation
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 82: WHERE id = v_id;
Line 83: END; $procedure$
Line 84: LANGUAGE plpgsql;
Line 85:
Line 86: Create or replace FUNCTION Increase_storage_pool_master_version(
Should be IncreaseStoragePoolMasterVersion
Line 87: v_id UUID)
Line 88: RETURNS INTEGER
Line 89: AS $procedure$
Line 90: DECLARE v_master_domain_version INTEGER;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java
Line 383: @Override
Line 384: public int increaseStoragePoolMasterVersion(Guid id) {
Line 385: MapSqlParameterSource parameterSource =
getCustomMapSqlParameterSource()
Line 386: .addValue("id", id);
Line 387: return
getCallsHandler().executeModificationReturnResult("Increase_storage_pool_master_version",
parameterSource);
name of SP should be changed , see comment in SP file
Line 388: }
Line 389:
--
To view, visit http://gerrit.ovirt.org/11500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2657ddfdbf2400f24341b07ab60743d6430481
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
