Alex Lourie has posted comments on this change. Change subject: packaging: allow importing existing ISO domain on setup ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/fedora/setup/engine-setup.py Line 465: "OPTION_LIST" :[], Line 466: "VALIDATION_FUNC" :validate.validateNFSMountPoint, Line 467: "DEFAULT_VALUE" :generateIsoDomainName(), Line 468: "MASK_INPUT" : False, Line 469: "LOOSE_VALIDATION": True, In this, if the path already exists, the user will be still told so, and allowed to continue. So this doesn't really saves a question to the user. Line 470: "CONF_NAME" : "NFS_MP", Line 471: "USE_DEFAULT" : False, Line 472: "NEED_CONFIRM" : False, Line 473: "CONDITION" : False}, Line 1767: controller.CONF["sd_uuid"] = str(entry) Line 1768: except ValueError: Line 1769: #Should we abort if something else exists here? Line 1770: continue Line 1771: else: OK, but what I meant is that I don't really like this construct...will think about a better way (if possible) Line 1772: # Generate the UUID for the isodomain Line 1773: controller.CONF["sd_uuid"] = nfsutils.generateUUID() Line 1774: Line 1775: # Create ISO domain -- To view, visit http://gerrit.ovirt.org/11556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a4343f8374e6439b0ee0a14fff233a0d4a0d5a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
