Sandro Bonazzola has posted comments on this change. Change subject: packaging: allow interactive NFS exports cleanup with engine-cleanup ......................................................................
Patch Set 3: No score (1 inline comment) .................................................... File packaging/fedora/setup/nfsutils.py Line 67: # backup existing configuration and update it Line 68: _backupOldNfsExports(exportFilePath) Line 69: with open(exportFilePath, "w") as exportFile: Line 70: exportFile.writelines(new_lines) Line 71: exportFile.truncate() Yes, you're right, it's a leftover as the seek in the previous with statement. I'll remove it. Line 72: return removed_exports Line 73: Line 74: Line 75: def setSELinuxContextForDir(path, contextName): -- To view, visit http://gerrit.ovirt.org/11548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
