Kanagaraj M has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickDetailMapper.java
Line 52: private static GlusterBrick mapBrickProperties(BrickDetails
detail, GlusterBrick model) {
Line 53: if (detail.getBrickProperties() != null) {
Line 54: BrickProperties props = detail.getBrickProperties();
Line 55: model.setBlockSize(props.getBlockSize());
Line 56: if (StringUtils.isNotEmpty(props.getDevice()))
Please use the java convention for braces(statements inside the if condition
should be enclosed by '{' and '}' ).
Line 57: model.setDevice(props.getDevice());
Line 58: model.setFreeSize(props.getFreeSize());
Line 59: if (StringUtils.isNotEmpty(props.getFsName()))
Line 60: model.setFsName(props.getFsName());
--
To view, visit http://gerrit.ovirt.org/11391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie219c7cf59fec8a21a54f34959ee5966eed7d524
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
