Eli Mesika has posted comments on this change.

Change subject: webadmin: Show clusters with Virt service enabled only for VM
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 649:     SELECT * FROM vds WHERE recoverable AND status = 10; --non 
operational
Line 650: END; $procedure$
Line 651: LANGUAGE plpgsql;
Line 652: 
Line 653: CREATE OR REPLACE FUNCTION getstorage_pool_by_virt_service_cluster() 
RETURNS SETOF storage_pool
getstorage_pool_by_virt_service_cluster => GetStoragePoolByVirtServiceCluster
Line 654:    AS $procedure$
Line 655: BEGIN
Line 656:    RETURN QUERY SELECT SP.* FROM STORAGE_POOL SP
Line 657:    WHERE EXISTS (SELECT 1 FROM VDS_GROUPS VG WHERE VG.VIRT_SERVICE = 
TRUE AND VG.STORAGE_POOL_ID = SP.ID);


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java
Line 385:     public List<storage_pool> getDataCentersWithVirtServiceCluster() {
Line 386:         MapSqlParameterSource parameterSource = 
getCustomMapSqlParameterSource();
Line 387:         StoragePoolRawMapper mapper = new StoragePoolRawMapper();
Line 388: 
Line 389:         return 
getCallsHandler().executeReadList("getstorage_pool_by_virt_service_cluster", 
mapper, parameterSource);
rename SP , see comment in SP file
Line 390:     }
Line 391: 


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAOHibernateImpl.java
Line 74:     public void updateStatus(Guid id, StoragePoolStatus status) {
Line 75:         // TODO Auto-generated method stub
Line 76: 
Line 77:     }
Line 78: 
I saw that Kublin started to delete all those *Hibernate files , so a change 
here is not needed
Line 79:     @Override
Line 80:     public void updatePartial(storage_pool pool) {
Line 81:         // TODO Auto-generated method stub
Line 82: 


--
To view, visit http://gerrit.ovirt.org/11395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb63c7e2addf525bb527d94694a8dfc752d69154
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to