Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 1: Looks good to me, but someone else must approve
Looks good to me.
I would like Eli and Mi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Gluster Volume Georeplication Stop
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Missing AuditLog messages here.
.
Yair Zaslavsky has posted comments on this change.
Change subject: core: compensation should not clean entities with associated
tasks
..
Patch Set 3: (1 inline comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: core: Fix possible NPE in VdsUpdateRunTimeInfo
..
Patch Set 1:
I am sorry, I cannot review this as I don't understand the implication of when
null not calling th
Ravi Nori has abandoned this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 2: Abandoned
Will submit a better patch
--
To view, visit http://gerrit.ovirt.org/9091
To unsubscribe, vi
Sharad Mishra has posted comments on this change.
Change subject: core: fix imports in MoveImageGroupVDSCommand
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9094
To unsubscribe, visit http://gerrit.ovirt.o
Sharad Mishra has posted comments on this change.
Change subject: core: Fix possible NPE in VdsUpdateRunTimeInfo
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9130
To unsubscribe, visit http://gerrit.ovirt.
Sharad Mishra has uploaded a new change for review.
Change subject: core: Fix possible NPE in VdsUpdateRunTimeInfo
..
core: Fix possible NPE in VdsUpdateRunTimeInfo
It is possible that vmDynamic is null which could lead to NPE
w
Liron Aravot has posted comments on this change.
Change subject: core: errors during preview of diskless snapshots
..
Patch Set 2:
I'lll submit the patch without the dependencies after reviews.
--
To view, visit http://gerrit.
Liron Aravot has uploaded a new change for review.
Change subject: core: errors during preview of diskless snapshots
..
core: errors during preview of diskless snapshots
1. When creating a diskless snapshot, then adding a disk t
Allon Mureinik has posted comments on this change.
Change subject: core: Disallow from remove of a DC when not all hosts are in
maintenance (#850286)
..
Patch Set 1: (1 inline comment)
Sort of agree with mkublin about the SP s
Allon Mureinik has posted comments on this change.
Change subject: core: renamed getVmNetworkInterfaceDAO to
getVmNetworkInterfaceDao
..
Patch Set 1: Looks good to me, but someone else must approve
Looks fine - but consider sq
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup ActivateDeactivateVmNicCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9126
To u
Allon Mureinik has posted comments on this change.
Change subject: core: compensation should not clean entities with associated
tasks
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
1. See inline
Moti Asayag has posted comments on this change.
Change subject: core: removed getVmNetworkInterfaceDao
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9105
To unsubscribe, visit http://gerri
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Added version dependency for webadmin-portal package
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Moti Asayag has posted comments on this change.
Change subject: core: renamed getVmNetworkInterfaceDAO to
getVmNetworkInterfaceDao
..
Patch Set 1: Looks good to me, approved
Thanks!
--
To view, visit http://gerrit.ovirt.org/9
Liron Aravot has abandoned this change.
Change subject: core: change vdsSpmId related command to support numerous vdss
..
Patch Set 14: Abandoned
--
To view, visit http://gerrit.ovirt.org/8277
To unsubscribe, visit http://gerri
Maor Lipchuk has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: (1 inline comment)
File
backen
Kiril Nesenko has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing (#BZ870070)
..
Patch Set 7:
Need to verify
--
To view, visit http://gerrit.ovirt.org/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added version dependency for webadmin-portal package
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Alex Lourie has posted comments on this change.
Change subject: packaging: Added version dependency for webadmin-portal package
..
Patch Set 1: Verified; No score
--
To view, visit http://gerrit.ovirt.org/9127
To unsubscribe, v
Alex Lourie has posted comments on this change.
Change subject: packaging: Added version dependency for webadmin-portal package
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Alex Lourie has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing (#BZ870070)
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view,
Maor Lipchuk has posted comments on this change.
Change subject: core: compensate on wrong object lead to NPE
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
.
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Added version dependency for webadmin-portal package
..
packaging: Added version dependency for webadmin-portal package
Change-Id: I5876c46e9709703f8ae
Michael Kublin has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager
..
Patch Set 20: I would prefer that you didn't submit this
(6 inline comments)
...
Michael Kublin has posted comments on this change.
Change subject: core: compensate on wrong object lead to NPE
..
Patch Set 5:
Fix is correct and it is really will solve a problem which is described at the
bug, but take a one
Allon Mureinik has posted comments on this change.
Change subject: core: Quota refactor - test and commands I
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9001
To un
Allon Mureinik has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager
..
Patch Set 20: Looks good to me, but someone else must approve
(2 inline comments)
minor issues, see inline
Liron Aravot has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Michael Kublin has posted comments on this change.
Change subject: core: compensation should not clean entities with associated
tasks
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9122
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: compensation should not clean entities with associated
tasks
..
Patch Set 3: Verified
Verified:
Crashed engine at Add disk , prior to finish of execution
Arik Hadas has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
..
Patch Set 1: (2 inline comments)
File
backend/manager/m
Allon Mureinik has posted comments on this change.
Change subject: core: Quota refactor - parameters
..
Patch Set 13: I would prefer that you didn't submit this
(4 inline comments)
giving -1 since there are some open issues IM
Allon Mureinik has posted comments on this change.
Change subject: core: compensate on wrong object lead to NPE
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9074
To u
Shireesh Anjal has posted comments on this change.
Change subject: engine: Added null check to avoid NPE
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9117
To unsubscr
Liron Aravot has abandoned this change.
Change subject: core: RemoveDiskCommand - added TODO comments
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/6604
To unsubscribe, visit http://gerrit.ovirt.org/settin
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: compensation should not clean entities with associated
tasks
..
core: compensation should not clean entities with associated tasks
Compensation should n
Omer Frenkel has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Liron Aravot has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 2: (3 inline comments)
..
Moti Asayag has posted comments on this change.
Change subject: core: removed getVmNetworkInterfaceDao
..
Patch Set 1: Looks good to me, but someone else must approve
Laszlo, I agree with the patch, however it will leave us wit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing http connection leak at proxy for SPM
..
Patch Set 1: Looks good to me, approved
Good catch!
--
To view, visit http://gerrit.ovirt.org/9116
To uns
Liron Aravot has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/9085
To unsubscribe, visit http://gerrit.ov
Liron Aravot has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.o
Liron Aravot has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Allon Mureinik has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: Looks good to me, but someone else must approve
I would also prefer adding getVmId
Simon Grinberg has posted comments on this change.
Change subject: packaging: validate MAC addresses range provided by the user
..
Patch Set 3:
Hi Hunt,
How do you fill about Moran suggestion to implement instead a generic so
Michael Kublin has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 2: (3 inline comments)
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 2:
Changed the clients parameter class from VdsActionParameters to
RemoveVdsParam
Liron Aravot has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
Allon Mureinik has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 2: Looks good to me, but someone else must approve
I'd separate
Michael Kublin has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9097
To u
Omer Frenkel has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9085
To unsubscribe, visi
Omer Frenkel has posted comments on this change.
Change subject: engine: Added null check to avoid NPE
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9117
To unsubscrib
Omer Frenkel has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 2:
you have to change the clients to use it, no?
otherwise it will fail when calling t
Dhandapani Gopal has uploaded a new change for review.
Change subject: engine: Added null check to avoid NPE
..
engine: Added null check to avoid NPE
If the qualified brick name is not available in the brick list,
may throug
Michael Kublin has posted comments on this change.
Change subject: core: Fixing http connection leak at proxy for SPM
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9116
To unsubscribe, visit http://gerrit.o
Michael Kublin has uploaded a new change for review.
Change subject: core: Fixing http connection leak at proxy for SPM
..
core: Fixing http connection leak at proxy for SPM
The following patch will fix a connection leak which w
Michael Kublin has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: (1 inline comment)
File
back
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 1: (2 inline comments)
Incorporated review comments.
Omer Frenkel has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 1: (1 inline comment)
File
backe
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Get Gluster Volume Profile Info Query
..
engine: Get Gluster Volume Profile Info Query
- New entity classes for Gluster Volume Profile Info
- New
Omer Frenkel has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8646
To unsubscribe,
Omer Frenkel has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8646
To unsubscribe, visit http
Juan Hernandez has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing (#BZ870070)
..
Patch Set 7: Looks good to me, but someone else must approve
--
To vie
67 matches
Mail list logo
