Liron Aravot has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 205: VdcBllErrors errorCode = e.getErrorCode();
Line 206:
Line 207: // if the returned exception is such that shoudn't
trigger the re-run process,
Line 208: // re-throw it. otherwise, continue (the vm will be
down and a re-run will be triggered)
Line 209: switch (errorCode) {
I think that's a little over defensive..and no flows will work that way - but
that's up to you.
If you already catch the exception, i'd set setSuccesful(false) instead of
expnensive re-throw..if you can please take a look at this option - though
that's a suggestion.
Line 210: case Done:
Line 211: case exist:
Line 212: throw e;
Line 213: default:
--
To view, visit http://gerrit.ovirt.org/9085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35569a2ebfbea3e8eb69b414c31748c49cb29841
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
