Maor Lipchuk has posted comments on this change. Change subject: core: compensate on wrong object lead to NPE ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 7: core: compensate on wrong object lead to NPE Line 8: Line 9: Compensation during unlock vm is performed on the vm itself and not on Line 10: the vm dynamic data, which causes to NPE during compensation process as Line 11: there the defined DAO for the status update is per vm dynamic. Please consider the following change: /s/as there the defined DAO for the status update is per vm dynamic./since the vm status update is executed on the vm dynamic. Line 12: Line 13: Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45 -- To view, visit http://gerrit.ovirt.org/9074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
