Yair Zaslavsky has posted comments on this change.
Change subject: engine: Gluster Volume Georeplication Stop
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Missing AuditLog messages here.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 770: ACTION_TYPE_FAILED_GLUSTER_VOLUME_ALREADY_STARTED=Cannot ${action}
${type}. Gluster Volume ${volumeName} already started.
Line 771: ACTION_TYPE_FAILED_GLUSTER_VOLUME_ALREADY_STOPPED=Cannot ${action}
${type}. Gluster Volume ${volumeName} already stopped.
Line 772: ACTION_TYPE_FAILED_GLUSTER_BRICK_INVALID=Cannot ${action} ${type}.
Invalid gluster brick.
Line 773: ACTION_TYPE_FAILED_BRICK_ID_REQUIRED=Cannot ${action} ${type}. Brick
ID is required.
Line 774: ACTION_TYPE_FAILED_NO_GEOREPLICATION_FOUND=Cannot ${action} ${type}.
Could not found the Gluster Volume Geo-replication.
Don't you want to have in the canDoAction msg an indication which gluster
volume is problematic?
Line 775: VMPAYLOAD_INVALID_PAYLOAD_TYPE=VM Payload only supported in CDROM or
Floppy devices
Line 776: VMPAYLOAD_SIZE_EXCEEDED=Payload is limited to ${size}K
Line 777: VMPAYLOAD_CDROM_EXCEEDED=Payload CDROM cannot be used when using an
additional CDROM
Line 778: VMPAYLOAD_FLOPPY_EXCEEDED=Payload Floppy cannot be used when using an
additional Floppy
--
To view, visit http://gerrit.ovirt.org/8922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea1eff5552f1cc84c12344db67c643ab97f6bc0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
