Allon Mureinik has posted comments on this change. Change subject: core: compensation should not clean entities with associated tasks ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) 1. See inline comment about IN vs EXISTS 2. Please add a DAO test for this new usecase. .................................................... File backend/manager/dbscripts/business_entity_snapshot_sp.sql Line 43: $procedure$ Line 44: BEGIN Line 45: RETURN QUERY SELECT DISTINCT business_entity_snapshot.command_id, business_entity_snapshot.command_type Line 46: FROM business_entity_snapshot Line 47: WHERE NOT EXISTS for such a get-all usecase, IN should perform better than exists: SELECT DISTINCT business_entity_snapshot.command_id, business_entity_snapshot.com mand_type FROM business_entity_snapshot WHERE command_id NOT IN (SELECT command_id FROM async_tasks); Line 48: ( Line 49: SELECT 1 Line 50: FROM async_tasks Line 51: WHERE async_tasks.command_id = business_entity_snapshot.command_id -- To view, visit http://gerrit.ovirt.org/9122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
