Omer Frenkel has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 27: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 28:
Line 29: @NonTransactiveCommandAttribute
Line 30: @LockIdNameAttribute
Line 31: public class RemoveVdsCommand<T extends GlusterServerParameters>
extends VdsCommand<T> {
I agree, should be new RemoveVdsParameters class
Line 32:
Line 33: private AuditLogType errorType =
AuditLogType.USER_FAILED_REMOVE_VDS;
Line 34: private VDS upServer;
Line 35:
--
To view, visit http://gerrit.ovirt.org/8894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b8fa947cd6a6ece79ecfe00041f54e31e9e7ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
