Allon Mureinik has posted comments on this change.

Change subject: core: Disallow from remove of a DC when not all hosts are in 
maintenance (#850286)
......................................................................


Patch Set 1: (1 inline comment)

Sort of agree with mkublin about the SP status - checking it instead of each 
host may be more elegant.

Question: are we sure there are no other flows that produce this status?

....................................................
Commit Message
Line 3: AuthorDate: 2012-11-07 21:29:34 +0200
Line 4: Commit:     Tal Nisan <tni...@redhat.com>
Line 5: CommitDate: 2012-11-07 21:29:34 +0200
Line 6: 
Line 7: core: Disallow from remove of a DC when not all hosts are in 
maintenance (#850286)
s/from remove/removing/
Line 8: 
Line 9: When trying to force remove a Data Center when not all it's hosts are
Line 10: in maintenance mode, fail the CanDoAction
Line 11: 


--
To view, visit http://gerrit.ovirt.org/9110
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88e2938d4c1b02065b330929e15c579f714e4385
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to