Omer Frenkel has posted comments on this change.
Change subject: core: JAXB annotations cleanup for common modules - vdscommands
..
Patch Set 1: Looks good to me, approved
please verify
--
To view, visit http://gerrit.ovirt.or
Ori Liel has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
..
Patch Set 5: (10 inline comments)
File
backend/manager/mo
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Added Gluster entities in REST schema
..
Patch Set 18:
Added version checks for gluster related types and states in
BackendCapabilitiesResource
--
To
Ori Liel has posted comments on this change.
Change subject: restapi: Gluster Resources Implementation classes
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3905
To unsubscribe,
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Added Gluster entities in REST schema
..
Patch Set 17: (1 inline comment)
New patch-set to follow, with version checks in BackendCapabilitiesResource f
Ori Liel has posted comments on this change.
Change subject: restapi: Gluster REST api - Create Gluster Volume
..
Patch Set 3: (1 inline comment)
File
backend/manager/module
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Resource interfaces for Gluster Volume(s)
..
Patch Set 12: (3 inline comments)
Responses inline.
Moti Asayag has uploaded a new change for review.
Change subject: core: Monitor any actions if executed with a correlation ID
..
core: Monitor any actions if executed with a correlation ID
Each action which is executed with a co
Eoghan Glynn has posted comments on this change.
Change subject: restapi: Gluster REST api - Create Gluster Volume
..
Patch Set 3: I would prefer that you didn't submit this
Hi Shireesh,
I would like to see a unit test for Bac
Eoghan Glynn has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
..
Patch Set 5: (1 inline comment)
Hi Shireesh,
One comment inline.
Juan brings up an interesting point, on
Sharad Mishra has posted comments on this change.
Change subject: engine: expose compatibility version/qemu machine type via
engine-config tool
..
Patch Set 1:
I think its single value in rhev environment. So, should we change
Tal Nisan has uploaded a new change for review.
Change subject: core: Converter comments removal
..
core: Converter comments removal
Signed-off-by: Tal Nisan
Change-Id: Iaa9b7d8e6380d90ee2d232d262af154464ef6f12
---
M
backend/m
Tal Nisan has uploaded a new change for review.
Change subject: core: JAXB annotations cleanup for common module - action
..
core: JAXB annotations cleanup for common module - action
Signed-off-by: Tal Nisan
Change-Id: Ie8ec55d
Tal Nisan has uploaded a new change for review.
Change subject: core: JAXB annotations cleanup for common modules -
businessentities
..
core: JAXB annotations cleanup for common modules - businessentities
Signed-off-by: Tal Nis
Tal Nisan has uploaded a new change for review.
Change subject: core: JAXB annotations cleanup for common module - errors
..
core: JAXB annotations cleanup for common module - errors
Signed-off-by: Tal Nisan
Change-Id: I3b1c569
Tal Nisan has uploaded a new change for review.
Change subject: core: JAXB annotations cleanup for common module - queries
..
core: JAXB annotations cleanup for common module - queries
Signed-off-by: Tal Nisan
Change-Id: Iddea1
Tal Nisan has uploaded a new change for review.
Change subject: core: JAXB annotations cleanup for common modules - vdscommands
..
core: JAXB annotations cleanup for common modules - vdscommands
Signed-off-by: Tal Nisan
Change-
Itamar Heim has posted comments on this change.
Change subject: core: Made all the public queries user queries
..
Patch Set 2: (2 inline comments)
highlighted obsoletes here
Moti Asayag has submitted this change and it was merged.
Change subject: core: Dont require activation.jar
..
core: Dont require activation.jar
This is part of rt.jar (part of the JRE) since Java 6, so there is
no need to bring
Dhandapani Gopal has uploaded a new change for review.
Change subject: engine: getUpServer method moved to new class ClusterUtils
..
engine: getUpServer method moved to new class ClusterUtils
getUpServer method moved from Glus
Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: Filter public queries
..
Patch Set 3:
Rebased on top of [http://gerrit.ovirt.org/3959].
--
To view, visit http://gerrit.ovirt.org/4035
To u
Vojtech Szocs has posted comments on this change.
Change subject: core: Made all the public queries user queries
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3959
To
Moti Asayag has posted comments on this change.
Change subject: core: Dont require activation.jar
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2354
To unsubscribe, visit http://gerrit.ovi
Juan Hernandez has posted comments on this change.
Change subject: core: Dont require activation.jar
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/2354
To unsubscribe, visit http://gerrit.ovirt.org/settings
Juan Hernandez has posted comments on this change.
Change subject: core: Dont require activation.jar
..
Patch Set 3:
No changes, just rebased.
--
To view, visit http://gerrit.ovirt.org/2354
To unsubscribe, visit http://gerrit.
Juan Hernandez has posted comments on this change.
Change subject: core: Remove dependency on JNA
..
Patch Set 2: Verified
No changes appart from rebasing. Hopefully it can be merged.
--
To view, visit http://gerrit.ovirt.org/
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 10:
New patch set ready for review, with following changes:
- Since updating network's "required" and "dis
Juan Hernandez has posted comments on this change.
Change subject: gitignore: ignore PLY-generated files
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3516
To unsubscr
BUILD SUCCESS
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/709/
Project: ovirt_engine_unit_tests
Date of build: Mon, 30 Apr 2012 13:25:48 -0400
Build duration: 29 min
CHANGE SET
Revision e38d43e5d1d640982bb7e5364986cefa09b05581 by lhornyak: (core: test fix)
change: edit
back
Juan Hernandez has uploaded a new change for review.
Change subject: sdk: Add session support
..
sdk: Add session support
This change adds support for session cookies sent by the server
and for the "Prefer: persistent-auth" head
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/708/
Project: ovirt_engine_unit_tests
Date of build: Mon, 30 Apr 2012 12:37:53 -0400
Build duration: 47 min
CHANGE SET
No changes
MAVEN ARTIFACTS
oVirt Build Tools
oVirt Server EAR
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/707/
Project: ovirt_engine_unit_tests
Date of build: Mon, 30 Apr 2012 11:42:08 -0400
Build duration: 55 min
CHANGE SET
Revision b9b14598627a9ab90fc9b5f8c7d00c78e111a7b7 by alkaplan: (webadmin: hot
plug nic)
change:
Alona Kaplan has posted comments on this change.
Change subject: userportal,webadmin: Add missing NON-NLS comments
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/706/
Project: ovirt_engine_unit_tests
Date of build: Mon, 30 Apr 2012 10:58:20 -0400
Build duration: 43 min
CHANGE SET
Revision 32067cce51bc2667d9e30032cdcf8997ba384836 by sesubram: (engine: Revert
Gluster User change
Ori Liel has posted comments on this change.
Change subject: restapi: Mappers for Gluster entities
..
Patch Set 8: (8 inline comments)
File
backend/manager/modules/compat/sr
Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: Add missing NON-NLS comments
..
Patch Set 2:
I've changed column header strings to empty strings (non-localized) due to the
way the UI is d
Allon Mureinik has posted comments on this change.
Change subject: core: Query auth by session-cached admin-status
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 revie
Allon Mureinik has posted comments on this change.
Change subject: core: Login Commands - add admin flag to VdcUser
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3956
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Login Commands - add admin flag to VdcUser
..
Patch Set 3:
rebase, no changes since last review.
--
To view, visit http://gerrit.ovirt.org/3956
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: Login comands - clean up authenticateUser
..
Patch Set 3: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/3955
To unsubscribe, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup login commands
..
Patch Set 3: Verified
rebased, fixed typo as per Oved's comment on the last patch.
--
To view, visit http://gerrit.ovirt.org/39
Allon Mureinik has posted comments on this change.
Change subject: core: SessionDataContainer: added setUser method
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebaese, no changes since last +1 rev
Allon Mureinik has posted comments on this change.
Change subject: core: Added VdcUser.isAdmin()
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebaese, no changes since last +2 review.
--
To view, v
Allon Mureinik has posted comments on this change.
Change subject: core: QueriesCommandBase rename type to queryType
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3951
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: User Queries
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
rebaese, no changes since last +1 review.
--
To view, visit http:/
Daniel Erez has submitted this change and it was merged.
Change subject: common: moving PlugUplug actions to actions package
..
common: moving PlugUplug actions to actions package
moving HotPlugUnplugVmNicParameters and PlugAct
Daniel Erez has posted comments on this change.
Change subject: common: moving PlugUplug actions to actions package
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3960
To unsubscribe, visit http://gerrit.ovi
Daniel Erez has posted comments on this change.
Change subject: common: moving PlugUplug actions to actions package
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3960
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Login Commands - add admin flag to VdcUser
..
Patch Set 2:
Yair - checked it, it works fine.
Thanks for the test case!
I still need to rebase the patch,
Daniel Erez has posted comments on this change.
Change subject: common: moving PlugUplug actions to actions package
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3960
To unsubscribe, visit
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: hot plug nic
..
webadmin: hot plug nic
no bz
- adding activate checkbox to vm-interface new window.
- adding activate-deactivate commands to vm
Daniel Erez has posted comments on this change.
Change subject: webadmin: hot plug nic
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3902
To unsubscribe, visit http://gerrit.ovir
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/705/
Project: ovirt_engine_unit_tests
Date of build: Mon, 30 Apr 2012 10:19:24 -0400
Build duration: 38 min
CHANGE SET
Revision bcaf17cd853f11c831c2a8127c5fd33428097d90 by lhornyak: (engine-core:
valueValidationFuncti
Juan Hernandez has abandoned this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/3934
To unsubscribe, visit http://gerrit.ovirt.org/settin
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup login commands
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/main/
Michael Pasternak has posted comments on this change.
Change subject: gitignore: ignore PLY-generated files
..
Patch Set 3:
Please rebase the change locally and upload again.
10nx
--
To view, visit http://gerrit.ovirt.org/351
Michael Pasternak has posted comments on this change.
Change subject: gitignore: ignore PLY-generated files
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3516
To unsubscribe, vis
Maor Lipchuk has submitted this change and it was merged.
Change subject: core,webadmin: Remove disks list from snapshots
..
core,webadmin: Remove disks list from snapshots
Remove disks list from snapshot creation, since partia
Maor Lipchuk has posted comments on this change.
Change subject: core,webadmin: Remove disks list from snapshots
..
Patch Set 2: Verified; Looks good to me, approved
Acked by mkolesnik and derez
--
To view, visit http://gerrit
Ori Liel has posted comments on this change.
Change subject: restapi: Added Gluster entities in REST schema
..
Patch Set 17: (1 inline comment)
File
backend/manager/modules/
Ori Liel has posted comments on this change.
Change subject: restapi: Resource interfaces for Gluster Volume(s)
..
Patch Set 12: (3 inline comments)
File
backend/manager/mod
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1:
On 04/30/2012 05:08 PM, juan.hernan...@redhat.com wrote:
> Juan Hernandez has posted comments on
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Revert Gluster User changes insert_predefined_roles
..
engine: Revert Gluster User changes insert_predefined_roles
Gluster User related cha
Omer Frenkel has posted comments on this change.
Change subject: engine: Revert Gluster User changes insert_predefined_roles
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3909
To unsubscri
Selvasundaram has posted comments on this change.
Change subject: engine: Revert Gluster User changes insert_predefined_roles
..
Patch Set 8: Verified
No code changes.
Rebased with upstream.
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: core: Login Commands - add admin flag to VdcUser
..
Patch Set 2:
I just reminded you a flow I would like you to check -
1. Define a group in IPA or AD
2. Define
Oved Ourfali has posted comments on this change.
Change subject: core: Added VdcUser.isAdmin()
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3952
To unsubscribe, visit http://gerrit.ovirt.
Oved Ourfali has posted comments on this change.
Change subject: core: SessionDataContainer: added setUser method
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3953
To
Oved Ourfali has posted comments on this change.
Change subject: core: Cleanup login commands
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Oved Ourfali has posted comments on this change.
Change subject: core: Login Commands - add admin flag to VdcUser
..
Patch Set 2: (1 inline comment)
File
backend/manager/mod
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1:
Copying the standard output to the log seems challenging to me: how do you
capture that output gene
Shireesh Anjal has posted comments on this change.
Change subject: engine: Gluster Volume Option Entity changed
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4038
To u
Shireesh Anjal has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
..
Patch Set 5:
I'm aware that the current REST api doesn't have any "volume" resource. However
I'm not sur
Oved Ourfali has posted comments on this change.
Change subject: core: Query auth by session-cached admin-status
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3957
To unsubscribe, visit ht
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Gluster Volume dialog - remove CIFS
..
webadmin: Gluster Volume dialog - remove CIFS
CIFS checkbox in the Create Volume Popup is removed as
currently th
Allon Mureinik has posted comments on this change.
Change subject: core: Query auth by session-cached admin-status
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3957
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Login Commands - add admin flag to VdcUser
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3956
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Login comands - clean up authenticateUser
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3955
To unsubscribe, visit http://gerrit.ovir
Kanagaraj M has uploaded a new change for review.
Change subject: engine: Gluster Volume Option Entity changed
..
engine: Gluster Volume Option Entity changed
GlusterVolumeOptionEntity equals method is comparing the volumeId,
bu
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup login commands
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Allon Mureinik has posted comments on this change.
Change subject: core: SessionDataContainer: added setUser method
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3953
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Added VdcUser.isAdmin()
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Allon Mureinik has posted comments on this change.
Change subject: core: QueriesCommandBase rename type to queryType
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3951
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: User Queries
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/3519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messag
Juan Hernandez has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
..
Patch Set 5:
There is no "volume" concept in the oVirt RESTAPI at the moment, as far as I
can tell. So t
Michael Pasternak has posted comments on this change.
Change subject: Allow quoting of strings with single or double quotes
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3514
To
Michael Pasternak has submitted this change and it was merged.
Change subject: Allow quoting of strings with single or double quotes
..
Allow quoting of strings with single or double quotes
Use regex that was suggested by Juan
Allon Mureinik has posted comments on this change.
Change subject: engine-core: BaseConditionFieldAutoCompleter cleanup
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2
Allon Mureinik has posted comments on this change.
Change subject: engine-core: valueValidationFunction cleanup
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2816
To u
Allon Mureinik has posted comments on this change.
Change subject: engine-core: valueValidationFunction cleanup
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2816
To u
Allon Mureinik has posted comments on this change.
Change subject: core: [kpm] AbstractSysprepQueryTest rewrite
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3962
To u
Allon Mureinik has posted comments on this change.
Change subject: userportal,webadmin: Filter public queries
..
Patch Set 1: Looks good to me, but someone else must approve
Looks good, but please rebase on top of Iad0bcbbb to
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1:
it's okay to log debug prints, but in this case in my view better solution will
be copying stdio
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: removing usued *.ui.xml files
..
webadmin: removing usued *.ui.xml files
no bz
Change-Id: I0126a75001993dd95b10029c52ca57b4b231b426
---
D
fron
Daniel Erez has posted comments on this change.
Change subject: webadmin: removing usued *.ui.xml files
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/3903
To unsubscribe
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 8:
Related backend patch has been already merged, going to rebase and verify
frontend changes.
--
To view
Shireesh Anjal has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
..
Patch Set 5:
The "Gluster Volumes" and existing "Volumes" in oVirt are totally different
entities, with
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1:
It is true that the you can get almost the same output using the debug flag. I
failed to see that.
Alona Kaplan has posted comments on this change.
Change subject: userportal,webadmin: Add missing NON-NLS comments
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add debug logging of the HTTP messages
..
Patch Set 1: (2 inline comments)
all info you retrieving in this patch automatically
available when proxy on
1 - 100 of 179 matches
Mail list logo
