Ori Liel has posted comments on this change. Change subject: restapi: Resource interfaces for Gluster Volume(s) ......................................................................
Patch Set 12: (3 inline comments) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java Line 40: We always add a single entity at a time, the way you did in GlusterVolumesResource. We don't allow adding multiple entites in one POST command anywhere else, so let's adhere to that here as well (This means that should receive a GlusterBrick, not GlusterBricks) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterOptionsResource.java Line 39: public Response add(GlusterOptions options); We always add a single entity at a time, the way you did in GlusterVolumesResource. We don't allow adding multiple entites in one POST command anywhere else, so let's adhere to that here as well (This means that should receive a GlusterOption, not GlusterOptions) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java Line 62: We don't allow DELETE at collection context anywhere in the application. It's not that DELETE on a collection is considered un-restful, as far as I know, but I believe it protects the user from a potential grave mistake. Be the reason what it may, I believe that uniformity in the API is paramount, so, considering that the user has a way to delete options (one-by-one), I would ask that resetAllOptions() be removed. -- To view, visit http://gerrit.ovirt.org/3364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97503702a4fc5eeedeaa44ad1aba7cd35919521a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
