Juan Hernandez has posted comments on this change. Change subject: restapi: RSDL metadata for gluster related REST api ......................................................................
Patch Set 5: There is no "volume" concept in the oVirt RESTAPI at the moment, as far as I can tell. So the Gluster prefix is redundant there. It might not be redundant in other cases. Also, I am not against redundancy, just prefer to avoid it in this particular case. I understand the need to have a different namespace for Gluster concepts, specially internally in the Java code (I would try to use different package names, if possible), but in the API I think that concepts should not have given names, like oVirt or Gluster. Imagine that you want to create a Gluster only version of the API. Would you use that "gluster" prefix there? Probably not. So why use it if you can avoid it? You probably had this naming discussion with other more RESTAPI knowledgeable people already, so take my comment just as a minor suggestion. -- To view, visit http://gerrit.ovirt.org/3918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2883e452b8f6bc4b51bd2199fbd712f56dd96ab5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
