Michael Pasternak has posted comments on this change. Change subject: sdk: Add debug logging of the HTTP messages ......................................................................
Patch Set 1: (2 inline comments) all info you retrieving in this patch automatically available when proxy on debug mode, i.e api = API(..., debug=True) so you basically don't need this change. .................................................... File src/ovirtsdk/infrastructure/proxy.py Line 82: if response.status < 400: http codes < 400 -> all errors Line 86: except socket.error, e: it was taken in consideration, the other errors will be delegated, this code only handles socket error -- To view, visit http://gerrit.ovirt.org/3934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82d9101ebae8197df6554992d583faacf6bc2a9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Jia <chuanchang....@gmail.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
