Shireesh Anjal has posted comments on this change. Change subject: restapi: Resource interfaces for Gluster Volume(s) ......................................................................
Patch Set 12: (3 inline comments) Responses inline. .................................................... File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java Line 40: This won't work when adding brick(s) to a gluster volume, in cases where it is a replicated or striped volume. e.g. If the volume is of type "distributed replicate" and replica count is 2, then one must add bricks in multiples of two, and the gluster file system will not allow adding these bricks one at a time. .................................................... File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterOptionsResource.java Line 39: public Response add(GlusterOptions options); Will do .................................................... File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java Line 62: This will mean that we will not support one of the features supported by the gluster CLI (resetting all options of a volume in one go). I'll add glusterfs folks as reviewers to comment on this. -- To view, visit http://gerrit.ovirt.org/3364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97503702a4fc5eeedeaa44ad1aba7cd35919521a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
