Eoghan Glynn has posted comments on this change. Change subject: restapi: RSDL metadata for gluster related REST api ......................................................................
Patch Set 5: (1 inline comment) Hi Shireesh, One comment inline. Juan brings up an interesting point, on the usage of the "gluster" prefix. Normally I would tend to agree with him on given names, but in this case on balance I think allowing "gluster" to leak into the API naming is acceptable as oVirt may in the future integrate with other storage technologies, in which glustevolumes versus nexentavolumes or whatever would provide a convenient distinction. Cheers, Eoghan .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml Line 1997: gluster_volume.stripe_count: 'xs:int' Didn't you change these counts to unsigned int in a previous patch? -- To view, visit http://gerrit.ovirt.org/3918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2883e452b8f6bc4b51bd2199fbd712f56dd96ab5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
