Juan Hernandez has posted comments on this change. Change subject: sdk: Add debug logging of the HTTP messages ......................................................................
Patch Set 1: It is true that the you can get almost the same output using the debug flag. I failed to see that. But that debug information will just go to the standard output of the process (or where the implementation of httplib decides to put it, it currently uses just "print" statements). I think it is better if the user of the SDK can decide where this output should go, using the standard python logging mechanisms. Regarding the 400 status code what I mean is that some codes less than 400 also need a treatment, in particular the redirection codes. -- To view, visit http://gerrit.ovirt.org/3934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82d9101ebae8197df6554992d583faacf6bc2a9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Jia <chuanchang....@gmail.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
