Ori Liel has posted comments on this change.
Change subject: restapi: Added Gluster entities in REST schema
..
Patch Set 7: (5 inline comments)
File
backend/manager/modules/
Ori Liel has posted comments on this change.
Change subject: restapi: Resource interfaces for Gluster Volume(s)
..
Patch Set 3: (2 inline comments)
File
backend/manager/modu
Oved Ourfali has uploaded a new change for review.
Change subject: core: using MLA in ValidateSession servlet
..
core: using MLA in ValidateSession servlet
This commit does the "isAdmin" testing using the MLA mechanism (as there
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplatesFromStorageDomain
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: reports integration changes
..
webadmin: reports integration changes
This commit does the neccesary adjustements in the reports integration
to
Oved Ourfali has posted comments on this change.
Change subject: webadmin: reports integration changes
..
Patch Set 9: Verified; Looks good to me, approved
Rebased. based on previous ACKs.
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: permission filtering for GetVdsInterfacesByVdsId
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Oved Ourfali has posted comments on this change.
Change subject: webadmin: reports integration changes
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/3339
To unsubscribe, visit http://gerrit.ovirt.org/settin
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplate
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1904
To u
Allon Mureinik has posted comments on this change.
Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId
..
Patch Set 3:
why have the DAO changes twice?
just build this patch on top of I774d326d - save
Daniel Erez has posted comments on this change.
Change subject: webadmin: reports integration changes
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3339
To unsubscribe, visit http://gerrit
Daniel Erez has posted comments on this change.
Change subject: webadmin: guide me stuck for orphan cluster
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3599
To unsubscribe, visit http://
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Start Gluster Volume
..
engine: Start Gluster Volume
Includes following related to the commands for "Start Gluster Volume"
- New BLL Action an
Omer Frenkel has posted comments on this change.
Change subject: engine: Start Gluster Volume
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3215
To unsubscribe, visit http://gerrit.ovirt.o
Selvasundaram has posted comments on this change.
Change subject: engine: Start Gluster Volume
..
Patch Set 8: Verified
Rebased with master.
No code change from patch7.
Please merge.
--
To view, visit http://gerrit.ovirt.org
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: guide me stuck for orphan cluster
..
webadmin: guide me stuck for orphan cluster
Change-Id: Ib4779626b7cef700b493c5194748054421ec8b2e
---
M
frontend/
Tal Nisan has posted comments on this change.
Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId
..
--
To view, visit http://gerrit.ovirt.org/2966
To unsubscribe, visit http://gerrit.ovirt.org/setti
Tal Nisan has posted comments on this change.
Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId
..
Patch Set 3: Verified
The relevant DAO test for the get method is already submitted in the
GetVmTe
Adam Litke has posted comments on this change.
Change subject: restapi: Avoid JSON NPE in SPM priority (#808629)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3476
To
Adam Litke has posted comments on this change.
Change subject: cli: Remove pregenerated parsing tables
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Looks good to me. I tested both the rpm build and
Daniel Erez has posted comments on this change.
Change subject: webadmin: I18N support (#786448)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3353
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: core: Filter GetTemplateInterfacesByTemplateIdQuery
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3582
To unsubscribe, vi
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Set Frontend query filter
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3510
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: webadmin: create gluster volume implementation
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3504
To unsubscribe, visit http
Daniel Erez has posted comments on this change.
Change subject: webadmin: gluster service checkbox to cluster
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3482
To unsubscribe, visit http:
Daniel Erez has posted comments on this change.
Change subject: webadmin: Update supported browser versions
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3137
To unsubscribe, visit http://
Daniel Erez has posted comments on this change.
Change subject: webadmin: Control refresh behavior (#802378)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3197
To unsubscribe, visit http:/
ovirt_engine_dao_unit_tests - Build # 599 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/599/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailm
Omer Frenkel has posted comments on this change.
Change subject: engine: Start Gluster Volume
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3215
To unsubscribe, visit http://gerrit.ovirt.o
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Update integer value of StorageType.All
..
core: Update integer value of StorageType.All
Updating the value of StorageType.All from 6 to -1
Stora
Yair Zaslavsky has posted comments on this change.
Change subject: core: Update integer value of StorageType.All
..
Patch Set 1: Verified; Looks good to me, approved
Acked-By: Omer Frenkel (before did the revert).
--
To view,
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Update integer value of StorageType.All
..
core: Update integer value of StorageType.All
Updating the value of StorageType.All from 6 to -1
StorageType w
Allon Mureinik has posted comments on this change.
Change subject: core: Filter GetTemplateInterfacesByTemplateIdQuery
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3582
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: DAO for a template's interfaces, filtered
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3581
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup VmNetworkInterfaceDAO and its test
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3580
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up imports in VmHandler
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3579
To unsubscribe, visit http://gerrit.ovirt.org/settin
Allon Mureinik has uploaded a new change for review.
Change subject: core: cleanup VmNetworkInterfaceDAO and its test
..
core: cleanup VmNetworkInterfaceDAO and its test
General cleanup - extract static row mappers, removed code
Allon Mureinik has uploaded a new change for review.
Change subject: core: Filter GetTemplateInterfacesByTemplateIdQuery
..
core: Filter GetTemplateInterfacesByTemplateIdQuery
Support permission filtering for
GetTemplateInterfac
Allon Mureinik has uploaded a new change for review.
Change subject: core: DAO for a template's interfaces, filtered
..
core: DAO for a template's interfaces, filtered
Added a permission filtered overload for
VmNetworkInterfaceD
Allon Mureinik has uploaded a new change for review.
Change subject: core: Clean up imports in VmHandler
..
core: Clean up imports in VmHandler
Replaced some FQCNs with imports.
Change-Id: I64cf8a4746d73f456607551ee38953de7e7bd
Oved Ourfali has posted comments on this change.
Change subject: core: support hot plug when adding a VM nic
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3457
To unsu
Oved Ourfali has posted comments on this change.
Change subject: core: DAL add active to vm_interface_view
..
Patch Set 3:
If the decision is to use active then you have +2 from me.
I think it is confusing, though.
--
To view,
Oved Ourfali has posted comments on this change.
Change subject: core: extract mappers for VmNetworkDao
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/dal/s
Oved Ourfali has posted comments on this change.
Change subject: engine-core: RunVm - filter out unplugged nics
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3205
To u
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Update supported browser versions
..
Patch Set 4:
Submitted new patch set, this one includes all the requirements, please review
guys :)
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3543
Oved Ourfali has submitted this change and it was merged.
Change subject: Revert "core: Update integer value of StorageType.All"
..
Revert "core: Update integer value of StorageType.All"
This reverts commit 35af19e34fdcd2c6624b
Oved Ourfali has posted comments on this change.
Change subject: Revert "core: Update integer value of StorageType.All"
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3577
To unsu
Yair Zaslavsky has reverted this change.
Change subject: Revert "core: Update integer value of StorageType.All"
..
Patch Set 6: Reverted
This patchset was reverted in change: I013fa94f37d5629cc6717fbf8d44650db85bc637
--
To vie
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Update integer value of StorageType.All
..
core: Update integer value of StorageType.All
Updating the value of StorageType.All from 6 to -1
Stora
Yair Zaslavsky has posted comments on this change.
Change subject: core: Update integer value of StorageType.All
..
Patch Set 6: Verified; Looks good to me, approved
Acked-By: Omer Frenkel
--
To view, visit http://gerrit.ovirt
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup storage server connection DAO
..
core: Cleanup storage server connection DAO
Defining a single mapper , and setting it to be
static
Chan
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup storage server connection DAO
..
Patch Set 4: Verified; Looks good to me, approved
Acked-By: Omer Frenkel
--
To view, visit http://gerrit.ovirt.o
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Remove JAXB from storage_server_connections
..
core: Remove JAXB from storage_server_connections
Removing JAXB annotations from storage_server_co
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove JAXB from storage_server_connections
..
Patch Set 3: Verified; Looks good to me, approved
Acked-By: Omer Frenkel
--
To view, visit http://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
Patch Set 1: (2 inline comments)
File
backend/manager/modul
Tal Nisan has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
--
To view, visit http://gerrit.ovirt.org/3543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding posix support to connections to DB and DAL
..
core: Adding posix support to connections to DB and DAL
Change-Id: Ie8626cd7579004ac1fb65f87554dd828
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Introduction and usage of StoragePoolValidator
..
core: Introduction and usage of StoragePoolValidator
StoragePoolValidator is introduced and its methods
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: PosixFS fields added to translation to XML RPC
..
core: PosixFS fields added to translation to XML RPC
Adding mountOptions and VfsType to the translation
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Introducing new App errors for Posix-fs validation
..
core: Introducing new App errors for Posix-fs validation
Introducing two new error messages -
a. Er
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding PosixStorageEnabled config value
..
core: Adding PosixStorageEnabled config value
Adding PosixStorageEnabled config value in order
to determine wh
Tal Nisan has submitted this change and it was merged.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
core: Permission filtering for GetVmTemplatesDisks
Change-Id: Ia9566bc9036a653d9477231fd05b9626e2f83d7
Tal Nisan has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
Patch Set 4: Looks good to me, approved
Rebased, no additional review needed
--
To view, visit http://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
Patch Set 4: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/3548
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
Patch Set 1:
agree with the reply - this is non issue.
--
To view, visit http://gerrit.ovirt.org/3543
To un
Tal Nisan has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3548
To unsubscribe, visit http://gerrit.ovirt.
Tal Nisan has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
Patch Set 1:
The user portal has access to the whole cluster entity, I figured that given
the fact it's not a se
Allon Mureinik has posted comments on this change.
Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId
..
Patch Set 2: (1 inline comment)
File
bac
Eli Mesika has submitted this change and it was merged.
Change subject: packaging: Fixed incorrect upgrade flow (#810685)
..
packaging: Fixed incorrect upgrade flow (#810685)
https://bugzilla.redhat.com/show_bug.cgi?id=810685
Eli Mesika has posted comments on this change.
Change subject: packaging: Fixed incorrect upgrade flow (#810685)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3546
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
..
Patch Set 1: (2 inline comments)
Basically looks good.
A few issues, though:
1. Add tests for the DAOs (at
Tal Nisan has posted comments on this change.
Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId
..
Patch Set 2: (1 inline comment)
File
backend/
Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed incorrect upgrade flow (#810685)
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Mike Kolesnik has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3548
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: core: Removing of diskInfoList from AddVmFromSnapshot
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/356
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/354
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Stop engine-notifierd service on cleanup (#796604)
..
Patch Set 1: Fails
(1 inline comment)
Fil
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmTemplatesDisks
..
Patch Set 2:
I don't understand the test in this patch.
First - it tests code that was not modified in th
Michael Kublin has posted comments on this change.
Change subject: core: add hotplug support when adding VM nic
..
Patch Set 2: (4 inline comments)
File
backend/manager/modu
Oved Ourfali has posted comments on this change.
Change subject: core: support hot plug when adding a VM nic
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3457
To unsu
Selvasundaram has posted comments on this change.
Change subject: engine: Start Gluster Volume
..
Patch Set 7: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/3215
To unsubscribe, visit http://gerrit.ovirt.org/sett
Oved Ourfali has posted comments on this change.
Change subject: core: DAL add active to vm_interface_view
..
Patch Set 1: (1 inline comment)
minor comment.
File
backend/ma
Oved Ourfali has posted comments on this change.
Change subject: core: unifiy hostplug cando checks under Vmcommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3455
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: core: extract mappers for VmNetworkDao
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
just remove whitespaces.
..
Oved Ourfali has posted comments on this change.
Change subject: core: add hotplug support when adding VM nic
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
.
Oved Ourfali has posted comments on this change.
Change subject: engine-core: RunVm - filter out unplugged nics
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3205
To u
Oved Ourfali has posted comments on this change.
Change subject: core: share common plug/unplug messages and checks
..
Patch Set 1: (5 inline comments)
minor comments, method names + comma which I think is not supposed to be th
Oved Ourfali has posted comments on this change.
Change subject: core: clean linq and convertion leftovers
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3451
To unsubscribe, visit http://g
Oved Ourfali has posted comments on this change.
Change subject: core: clean XML annotations
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3450
To unsubscribe, visit http://gerrit.ovirt.or
Roy Golan has submitted this change and it was merged.
Change subject: core: attach logical networt to cluster as VM network by default
..
core: attach logical networt to cluster as VM network by default
https://bugzilla.redhat
Roy Golan has posted comments on this change.
Change subject: core: attach logical networt to cluster as VM network by default
..
Patch Set 2: Looks good to me, approved
acked already by ovedo
--
To view, visit http://gerrit.o
Roy Golan has posted comments on this change.
Change subject: core: attach logical networt to cluster as VM network by default
..
Patch Set 2: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3556
To unsubscribe, visi
Gal Hammer has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 8:
Thanks for the pythoncom.CoInitialize() tip!
I've tested the your patch and on a VM wi
Oved Ourfali has submitted this change and it was merged.
Change subject: core: ValidateSession servlet fixes
..
core: ValidateSession servlet fixes
Previous commit added this servlet, that validates the session, and
returns th
Oved Ourfali has posted comments on this change.
Change subject: core: ValidateSession servlet fixes
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3535
To unsubscribe, visit http
Roy Golan has posted comments on this change.
Change subject: core: ValidateSession servlet fixes
..
Patch Set 2: Looks good to me, approved
(2 inline comments)
File
fronte
Alex Lourie has posted comments on this change.
Change subject: packaging: Stop engine-notifierd service on cleanup (#796604)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://ge
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Stop engine-notifierd service on cleanup (#796604)
..
packaging: Stop engine-notifierd service on cleanup (#796604)
https://bugzilla.redhat.com/show_bu
Roy Golan has posted comments on this change.
Change subject: core: make VM network default true
..
Patch Set 1:
in order to set the VM usage to false send emtpy usages
POST /api/networks
test
true
1 - 100 of 284 matches
Mail list logo
