Allon Mureinik has posted comments on this change.

Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByVmTemplateIdQuery.java
Line 36: 
I didn't mean disk permissions (a feature which isn't implemented yet), but 
features on VM templates.

The user_storage_domains_view takes vm templates into account anyway, so this 
additional check is redundant.

--
To view, visit http://gerrit.ovirt.org/2966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I136016e5b2a28c5a0ee4c1ba87b0f1c312db7241
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to