Oved Ourfali has posted comments on this change. Change subject: core: add hotplug support when adding VM nic ......................................................................
Patch Set 1: I would prefer that you didn't submit this (4 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java Line 80: remove whitespaces. Line 84: succeded = hotPlugNic(vmDevice, vmDynamic); s/succeded/succeeded Line 103: VmStatic vm = DbFacade.getInstance().getVmStaticDAO().get(getParameters().getVmId()); Add a test on whether hotplug is supported by engine + OS. Line 109: List<VmNetworkInterface> interfaces = DbFacade.getInstance().getVmNetworkInterfaceDAO() remove whitespaces. -- To view, visit http://gerrit.ovirt.org/3453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64adbc2ab0f30a3ba532ddd8cc5986528b4b079b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
