Oved Ourfali has posted comments on this change.
Change subject: core: share common plug/unplug messages and checks
......................................................................
Patch Set 1: (5 inline comments)
minor comments, method names + comma which I think is not supposed to be there,
but on the other hand I'm not a native speaker :-)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 499: public boolean isHotPlugSupported() {
isSupported and isOsSupporting is a bit confusing, so documentation will help
here, or consider changing to isEngineSupporting... and isOSSupporting...
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 644: HOT_PLUG_IS_NOT_SUPPORTED=Activate/Deactivate while VM is running, is
only supported for Clusters of version 3.1 and above.
Remove the comma.
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 642: HOT_PLUG_IS_NOT_SUPPORTED=Activate/Deactivate while VM is running, is
only supported for Clusters of version 3.1 and above.
remove the comma.
....................................................
File
frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 619: HOT_PLUG_IS_NOT_SUPPORTED=Activate/Deactivate while VM is running, is
only supported for Clusters of version 3.1 and above.
remove the comma.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 642: HOT_PLUG_IS_NOT_SUPPORTED=Activate/Deactivate while VM is running, is
only supported for Clusters of version 3.1 and above.
remove the comma.
--
To view, visit http://gerrit.ovirt.org/3452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2430b965b8456e1a59fbb46b04fd6f59ef27a899
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
