Allon Mureinik has posted comments on this change. Change subject: core: permission filtering for getAllForVdsGroup ......................................................................
Patch Set 1: (2 inline comments) Basically looks good. A few issues, though: 1. Add tests for the DAOs (at least) 2. some minor inline comments 3. Question: the search you're replacing uses cluster name, this query uses cluster ID - did you check the User Portal can easily change from one to the other? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsByClusterIdParameters.java Line 9: remove the @Xml* modifiers - they're not used anymore. Line 21: here too. -- To view, visit http://gerrit.ovirt.org/3543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb27c75bed6c824bf367a8244a4c6163307bb64e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
