Allon Mureinik has posted comments on this change. Change subject: core: Permission filtering for GetVmTemplatesDisks ......................................................................
Patch Set 2: I don't understand the test in this patch. First - it tests code that was not modified in the test. Second - it repeats existing tests (see testGetAllForVMFilteredWithPermissions* methods). Perhaps the code from assertCorrectResult should be used instead of the existing assertFullGetAllForVMResult - but in a separate patch. -- To view, visit http://gerrit.ovirt.org/3548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9566bc9036a653d9477231fd05b9626e2f83d79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
