Roy Golan has posted comments on this change.

Change subject: core: ValidateSession servlet fixes
......................................................................


Patch Set 2: Looks good to me, approved

(2 inline comments)

....................................................
File 
frontend/wars/rmw-war/src/main/java/org/ovirt/engine/core/validate/ValidateSession.java
Line 79:                     log.error("User is not an administrator");
I think security wise its better to write this as DEBUG and not error.

Line 94:             out.print(upn);
can be inlined to response.getWriter().print(upn)

--
To view, visit http://gerrit.ovirt.org/3535
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61253ad591bd339f1b32ba4129fcbd9258dc811b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to