[Engine-patches] Change in ovirt-engine[master]: core: Task Manager Add Default Command Monitoring

2012-01-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Task Manager Add Default Command Monitoring .. Patch Set 5: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: Task Manager Add Jobs handling on server startup

2012-01-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Task Manager Add Jobs handling on server startup .. Patch Set 4: (1 inline comment) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: core: Task Manager Add stored-procedures

2012-01-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Task Manager Add stored-procedures .. Patch Set 4: (2 inline comments) File backend/manager/dbscripts/j

[Engine-patches] Change in ovirt-engine[master]: core: Task Manager Add business entities

2012-01-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Task Manager Add business entities .. Patch Set 4: (7 inline comments) File backend/manager/modules/co

[Engine-patches] Change in ovirt-guest-agent[master]: agent: replaced init.d style script to systemd.

2012-01-25 Thread ghammer
Gal Hammer has uploaded a new change for review. Change subject: agent: replaced init.d style script to systemd. .. agent: replaced init.d style script to systemd. Change-Id: I196cfd5cfe1d53edd4bb45be1b3d1247663cb50a --- M confi

[Engine-patches] Change in ovirt-guest-agent[master]: agent: removed some requires from the spec file as a respons...

2012-01-25 Thread ghammer
Gal Hammer has uploaded a new change for review. Change subject: agent: removed some requires from the spec file as a response to Pavel Zhukov's comments. .. agent: removed some requires from the spec file as a response to Pavel

[Engine-patches] Change in ovirt-guest-agent[master]: agent: more spec file fixes after Stephen Gordon's review.

2012-01-25 Thread ghammer
Gal Hammer has uploaded a new change for review. Change subject: agent: more spec file fixes after Stephen Gordon's review. .. agent: more spec file fixes after Stephen Gordon's review. Change-Id: Ic2a1fc10e51b70391dcde8abb9a6a3

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-25 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 1: (10 inline comments) File backend

[Engine-patches] Change in ovirt-reports[master]: reports: removed trailing white spaces.

2012-01-25 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: reports: removed trailing white spaces. .. reports: removed trailing white spaces. Change-Id: I458021eca19cad95d1007847db1a268a8598db63 --- M reports/jars/ChartsC

[Engine-patches] Change in ovirt-reports[master]: reports: fixed poms maven files.

2012-01-25 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: reports: fixed poms maven files. .. reports: fixed poms maven files. - Now pulls version from root. - Also removed internal repository entry. Change-Id: I2fe40a03

[Engine-patches] Change in ovirt-dwh[master]: etl: removed unreachable maven repositories.

2012-01-25 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: etl: removed unreachable maven repositories. .. etl: removed unreachable maven repositories. Change-Id: Ic9c9b923c4b7dfce6144628384784dcce2fda953 --- M data-wareho

[Engine-patches] Change in ovirt-dwh[master]: history: changed daily table time column to type date (#7831...

2012-01-25 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: history: changed daily table time column to type date (#783197) .. history: changed daily table time column to type date (#783197) - Added development 3.1 views to

[Engine-patches] Change in ovirt-dwh[master]: history: removed trailing white spaces

2012-01-25 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: history: removed trailing white spaces .. history: removed trailing white spaces Change-Id: Iecc429f77792f74e169bb92dd25e73dc28164e42 --- M data-warehouse/history_

[Engine-patches] Change in ovirt-dwh[master]: etl: fixed avg calculation of vm disk read\write rate. (#781...

2012-01-25 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: etl: fixed avg calculation of vm disk read\write rate. (#781470) .. etl: fixed avg calculation of vm disk read\write rate. (#781470) This is a temporary fix that w

[Engine-patches] Change in ovirt-engine[master]: Preparation for query permissions - allow typing of queries ...

2012-01-25 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Preparation for query permissions - allow typing of queries as admin/user queries and add runAsUser property to params .. Patch Set 1: I don't have any comment on

[Engine-patches] Change in ovirt-engine[master]: Preparation for query permissions - allow typing of queries ...

2012-01-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: Preparation for query permissions - allow typing of queries as admin/user queries and add runAsUser property to params .. Patch Set 1: I would prefer that you d

[Engine-patches] Change in ovirt-engine[master]: core : Fixing directory search unit test

2012-01-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing directory search unit test .. core : Fixing directory search unit test The following cjhange should fix an unit test : testGetRootDSEReac

[Engine-patches] Change in ovirt-engine[master]: core : Fixing directory search unit test

2012-01-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Fixing directory search unit test .. Patch Set 2: Verified; Looks good to me, approved Already acked -- To view, visit http://gerrit.ovirt.org/1242 To u

[Engine-patches] Change in ovirt-engine[master]: core : Fixing directory search unit test

2012-01-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Fixing directory search unit test .. -- To view, visit http://gerrit.ovirt.org/1242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

[Engine-patches] Change in ovirt-engine[master]: core : Fixing directory search unit test

2012-01-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Fixing directory search unit test .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1242 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core : Fixing directory search unit test

2012-01-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Fixing directory search unit test .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/1242 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: Preparation for query permissions - allow typing of queries ...

2012-01-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: Preparation for query permissions - allow typing of queries as admin/user queries and add runAsUser property to params .. Preparation for query permissions - a

[Engine-patches] Change in ovirt-engine[master]: history: dwh views - removed templates disks and nics (#781...

2012-01-25 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: history: dwh views - removed templates disks and nics (#781979) .. history: dwh views - removed templates disks and nics (#781979) Since we do not collec

[Engine-patches] Change in ovirt-engine[master]: history: dwh views - removed templates disks and nics (#781...

2012-01-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: history: dwh views - removed templates disks and nics (#781979) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1234

[Engine-patches] Change in ovirt-engine[master]: remove scripts dependencies on specific jar versions

2012-01-25 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: remove scripts dependencies on specific jar versions .. Patch Set 8: Verified; Looks good to me, but someone else must approve (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: core : Fixing directory search unit test

2012-01-25 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core : Fixing directory search unit test .. core : Fixing directory search unit test The following cjhange should fix an unit test : testGetRootDSEReachableSer

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - support long host fqdn in create_c...

2012-01-25 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup - support long host fqdn in create_ca (#782810) .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Add the root cause message

2012-01-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add the root cause message .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1224 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: remove scripts dependencies on specific jar versions

2012-01-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: remove scripts dependencies on specific jar versions .. Patch Set 8: Looks good to me, but someone else must approve (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: core: Resolve keystore path correctly (#784328) .. core: Resolve keystore path correctly (#784328) https://bugzilla.redhat.com/784328 When the power ma

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Resolve keystore path correctly (#784328) .. Patch Set 5: Verified; Looks good to me, approved Rebased patch. -- To view, visit http://gerrit.ovirt.org/12

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: storage tab is sluggish (#769615)

2012-01-25 Thread danny . ran
Danny Rankevich has posted comments on this change. Change subject: backend, webadmin: storage tab is sluggish (#769615) .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1226 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Resolve keystore path correctly (#784328) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1233 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: remove scripts dependencies on specific jar versions

2012-01-25 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: remove scripts dependencies on specific jar versions .. Patch Set 8: (1 inline comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: webadmin: avoid exception in default behaviour

2012-01-25 Thread danny . ran
Danny Rankevich has submitted this change and it was merged. Change subject: webadmin: avoid exception in default behaviour .. webadmin: avoid exception in default behaviour no bz Refresh Manager: In case there is no cookie fo

[Engine-patches] Change in ovirt-engine[master]: webadmin: avoid exception in default behaviour

2012-01-25 Thread danny . ran
Danny Rankevich has posted comments on this change. Change subject: webadmin: avoid exception in default behaviour .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1227 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Resolve keystore path correctly (#784328) .. Patch Set 4: Rebased. -- To view, visit http://gerrit.ovirt.org/1233 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Task Manager Add business entities

2012-01-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Task Manager Add business entities .. Patch Set 4: The ExecutionContext and JobRepository interface were re-submitted on a separate commits. JobRepository

[Engine-patches] Change in ovirt-engine[master]: core: Task Manager Add business entities

2012-01-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Task Manager Add business entities .. Patch Set 4: job and step entities are referred as value objects.persistence will be done in dal layer by the JobRepos

[Engine-patches] Change in ovirt-engine[master]: core: Task Manager Add ExecutionContext

2012-01-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Task Manager Add ExecutionContext .. Patch Set 2: The ExecutionContext moved from the common to bll project, detached from the business entities of the task

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Resolve keystore path correctly (#784328) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1233 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set correct return type of GetoVirtISOsQuery

2012-01-25 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Set correct return type of GetoVirtISOsQuery .. webadmin: Set correct return type of GetoVirtISOsQuery Changes the previous String return type t

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set correct return type of GetoVirtISOsQuery

2012-01-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Set correct return type of GetoVirtISOsQuery .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1223 To unsub

[Engine-patches] Change in ovirt-engine[master]: engine: allow search events by object id

2012-01-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: allow search events by object id .. Patch Set 2: (4 inline comments) have added Einav to check if we need any code changes at the client side as well. ...

[Engine-patches] Change in ovirt-engine[master]: remove scripts dependencies on specific jar versions

2012-01-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: remove scripts dependencies on specific jar versions .. Patch Set 7: (3 inline comments) See my comments inside. ..

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: core: Resolve keystore path correctly (#784328) .. -- To view, visit http://gerrit.ovirt.org/1233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: core: Resolve keystore path correctly (#784328) .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1233 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: remove scripts dependencies on specific jar versions

2012-01-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: remove scripts dependencies on specific jar versions .. Patch Set 6: (1 inline comment) There is one leftover from a failed merge. See the comments inside. Apar

[Engine-patches] Change in ovirt-engine[master]: remove scripts dependencies on specific jar versions

2012-01-25 Thread rgolan
Roy Golan has abandoned this change. Change subject: remove scripts dependencies on specific jar versions .. Patch Set 5: Restored -- To view, visit http://gerrit.ovirt.org/837 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: core: Resolve keystore path correctly (#784328)

2012-01-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Resolve keystore path correctly (#784328) .. Patch Set 3: Rebased and changed the commit message as Per Moti comment. -- To view, visit http://gerrit.ovi