Juan Hernandez has posted comments on this change. Change subject: remove scripts dependencies on specific jar versions ......................................................................
Patch Set 7: (3 inline comments) See my comments inside. .................................................... File backend/manager/conf/ca/store-utils.sh Line 31: JB_HOME=/usr/local/jboss-eap-5.0/jboss-as This is not part of your change, but it doesn't it need to be replaced for JBoss 7? Line 40: CP=$EAR_LIB/engine-encryptutils.jar:$EAR_LIB/engine-compat.jar:$JB_HOME/common/lib/commons-logging.jar:$EAR_LIB/commons-codec-1.4.jar Doesn't this "common/lib" need to be replaced with "modules/..."? Or /usr/share/java/commons-logging.jar? .................................................... File backend/manager/conf/kerberos/engine-manage-domains Line 108: CP=$CONF_DIR:$JAVA_LIB_HOME/commons-logging.jar:$JAVA_LIB_HOME/commons-collections.jar:$JAVA_LIB_HOME/commons-lang.jar:$JAVA_LIB_HOME/commons-configuration.jar:$JAVA_LIB_HOME/commons-jxpath.jar:$JAVA_LIB_HOME/log4j.jar:$JAVA_LIB_HOME/commons-codec.jar:$JAVA_LIB_HOME/postgresql-jdbc.jar:$LOCAL_LIB/engine-compat.jar:$JAVA_LIB_HOME/engine-tools-common.jar:$ENGINE_LIB_PATH/engine-utils.jar:$ENGINE_LIB_PATH/engine-common.jar:$ENGINE_LIB_PATH/spring-tx-2.5.6.SEC02.jar:$ENGINE_LIB_PATH/commons-lang-2.4.jar:$ENGINE_LIB_PATH/spring-beans-2.5.6.SEC02.jar:$ENGINE_LIB_PATH/spring-core-2.5.6.SEC02.jar:$ENGINE_LIB_PATH/spring-ldap-core-1.3.0.RELEASE.jar:$ENGINE_LIB_PATH/engineencrypt-utils.jar Should be "engine-encryptutils.jar" instead of "engineencrypt-utils.jar". -- To view, visit http://gerrit.ovirt.org/837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1dc9733159cf9a542c3846e3e304216d5fc34d5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
