Maor Lipchuk has posted comments on this change.
Change subject: core: Task Manager Add business entities
......................................................................
Patch Set 4: (7 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
Line 20: public class Job extends IVdcQueryable implements BusinessEntity<Guid>
{
Please consider adding validation annotation for this business entity
Line 45: private String description;
Validation annotation for description size can be add here.
Line 285: public void prettyPrint() {
What is the use of this method, besides test?
Why not simply move it to the JobRepositoryDaoTest instead.
Line 287: System.out.println(String.format("%10s %20s %30s %30s %30s",
Please use log here instead System.out.println
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java
Line 16: public class Step extends IVdcQueryable implements
BusinessEntity<Guid> {
Please consider adding validation annotation for this business entity
Line 46: private String description;
Validation annotation for description size can be add here.
Line 263: public void prettyPrint(int i) {
See my comment referencing the same method on Job business entity.
System.out should be referenced as log
--
To view, visit http://gerrit.ovirt.org/1085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc2351d2bb35cbad641f7ea0be93252602685ab0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
