Maor Lipchuk has posted comments on this change. Change subject: core: Task Manager Add Default Command Monitoring ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java Line 129: JobRepositoryFactory.getJobRepository().updateStep(step); Maybe its better to also put this code line as part of the condition scope above (step != null) Also adding error logs when getting null values, for stepId or step entity, could be much helpful. -- To view, visit http://gerrit.ovirt.org/1089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a0ee368f63ec5bdf54ef18072a45fe8f01acbde Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
