Itamar Heim has posted comments on this change. Change subject: Preparation for query permissions - allow typing of queries as admin/user queries and add runAsUser property to params ......................................................................
Patch Set 1: I don't have any comment on the actual change. only that it is considered bad practice to mix logical changes with cleanups, as they make the patch harder to review and to analyze later if needed. it also makes it harder to cherry-pick to other branches. so a good practice is to send a separate patch on cleanups (you added finals, changed comment spelling, deleted comments, fixed whitespace/tab noise issues, etc) these are all great, but should have gone into another patch (git allows doing this after the fact as well) -- To view, visit http://gerrit.ovirt.org/1243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83c3f85a9ad41638135c4c05a2660a27fda67a1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
