Maor Lipchuk has posted comments on this change.
Change subject: core: Task Manager Add stored-procedures
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File backend/manager/dbscripts/job_sp.sql
Line 425: where step.external_id is not null);
I think this sql is equivalent to:
update step
set status = 'UNKNOWN'
where status = 'STARTED'
and job_id is null;
Line 432: where step.external_id is not null);
The double negative condition here is a bit confusing, same thing for the same
alias name for the step table.
maybe consider write it as positive condition, such as follow :
....job_id in (select step.job_id
from step
where step.external_id is null);
--
To view, visit http://gerrit.ovirt.org/1084
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib991f991824894aa4fee91754104d67b965aabda
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
