Michael Kublin has posted comments on this change.
Change subject: Preparation for query permissions - allow typing of queries as
admin/user queries and add runAsUser property to params
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(6 inline comments)
The commit contains a lot reverts fo changes which were done for
CommandsFactory class, I don't think that these were intention of the patch
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
Line 35:
This is also revert of the previous commit to that file, the following method
is not used anywehere
Line 36: public static boolean canDoActionWithParameters(VdcActionType
action,
This is also revert of the previous commit to that file, the following method
is not used anywehere
Line 66: */
Please remove java.lang and similar prefixes
Line 123: } finally {
contructor can not be null
Line 129:
This is revert of previous commit
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
Line 140:
please make those method similar to method in CommandBase : getActionType()
also please add and internal variable queryType or something like that,
possible you will use getQueryType a lot so why calculate it
--
To view, visit http://gerrit.ovirt.org/1243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83c3f85a9ad41638135c4c05a2660a27fda67a1e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
