markt-asf commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2285673300
This PR doesn't appear to change the current behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Furytron commented on PR #744:
URL: https://github.com/apache/tomcat/pull/744#issuecomment-2286295550
I just wanted to point out that we had a similar issue to
[VRBogdanov](https://github.com/apache/tomcat/pull/742#issuecomment-2275626750)
where upgrading to 9.0.93 from 9.0.91, starting th
adwsingh commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2286587792
The intention of the PR was to demonstrate if we could safely not close a
connection on a application sent 4xx but always safely close it on HTTP parsing
failures. I wanted to get feedback
markt-asf commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2288295442
Ah, understood. My view is that this is a neat trick but it isn't
sufficient. There are a bunch of places where Tomcat calls
`response.sendError(400,"reason")` where we also want the conne
adwsingh commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2289602433
@markt-asf I think Tomcat reserving existing HTTP 4xx responses solely for
its internal use is very restrictive to the application.
What do you feel about, adding a new field in the Coyo
markt-asf commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2290947428
Tomcat isn't reserving all 4xx responses. It will close the connection if a
small sub-set of those status codes is used and does so to avoid various
potential security issues. Applications
htdebeer opened a new pull request, #745:
URL: https://github.com/apache/tomcat/pull/745
When invoking a method on a proxied statement returns `null`, that
statement's proxy should also return `null`.
In particular, `Statement#getResultSet` should not return a `ResultSetProxy`
when t
htdebeer commented on PR #745:
URL: https://github.com/apache/tomcat/pull/745#issuecomment-2301162263
Created [bug ticket](https://bz.apache.org/bugzilla/show_bug.cgi?id=69279)
for this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
markt-asf merged PR #745:
URL: https://github.com/apache/tomcat/pull/745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
marcosemiao opened a new pull request, #60:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/60
The -exclude parameter with the -matchExcludesAgainstPathName parameter only
works for file names and not on the directory. When calling isExcluded with the
matchExcludesAgainstPath
sundarrajboobalan opened a new pull request, #746:
URL: https://github.com/apache/tomcat/pull/746
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
csutherl closed pull request #746: review my code
URL: https://github.com/apache/tomcat/pull/746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-uns
csutherl commented on PR #746:
URL: https://github.com/apache/tomcat/pull/746#issuecomment-2312385197
I'm not sure what the goal of this was, or if it was an accident, but this
isn't usable so closing.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dsoumis opened a new pull request, #747:
URL: https://github.com/apache/tomcat/pull/747
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf merged PR #747:
URL: https://github.com/apache/tomcat/pull/747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
Chenjp opened a new pull request, #748:
URL: https://github.com/apache/tomcat/pull/748
translation improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
markt-asf commented on PR #748:
URL: https://github.com/apache/tomcat/pull/748#issuecomment-2326608678
Thanks for the PR, but translations are managed via POEditor. See
https://cwiki.apache.org/confluence/display/TOMCAT/Managing+translations
We would very much appreciate it if you pro
markt-asf commented on PR #748:
URL: https://github.com/apache/tomcat/pull/748#issuecomment-2328089506
Many thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Oelje opened a new pull request, #749:
URL: https://github.com/apache/tomcat/pull/749
To avoid duplicate headers in the response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
markt-asf commented on PR #749:
URL: https://github.com/apache/tomcat/pull/749#issuecomment-2337580759
Under what circumstances are you seeing duplicate headers? That should never
happen. If the application is setting the `T-E` header that would be an
application bug.
If we did want
Oelje commented on PR #749:
URL: https://github.com/apache/tomcat/pull/749#issuecomment-2339895689
We are using a reverse proxy on TomCat. This proxy passes the responses from
the backend 1:1, including the TE header. This wasn't a problem for a long
time because the upstream firewall had
markt-asf commented on PR #749:
URL: https://github.com/apache/tomcat/pull/749#issuecomment-2340093524
Reverse proxies are a lot more complicated than simply echoing bytes from
input to output as you are discovering.
Closing this PR as this is an application issue.
--
This is an au
Chenjp opened a new pull request, #750:
URL: https://github.com/apache/tomcat/pull/750
SynchronizedStack#setLimit: when set a new limit which is less than current
capacity, shrink elements array and update index are expected.
pls see TestSynchronizedStack#testResetLowerLimit()
--
T
Chenjp opened a new pull request, #751:
URL: https://github.com/apache/tomcat/pull/751
FastHttpDateFormat#getCurrentDate() returns same string for two different
second datetime.
For following date:
1st:1726041009036, Wed, 11 Sep 2024 07:50:09 GMT
2nd:1726041009940, Wed, 11 Sep 2
markt-asf closed pull request #748: i18n zh translation improvement for 9.0.x
URL: https://github.com/apache/tomcat/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf commented on PR #750:
URL: https://github.com/apache/tomcat/pull/750#issuecomment-2343275006
This PR will not be applied.
`SynchronizedStack` is deliberately designed not to support shrinking the
stack because:
- Tomcat doesn't need the capability to shrink the stack
-
markt-asf closed pull request #750: Resize elements array and update index in
SynchronizedStack#setLimit when needed
URL: https://github.com/apache/tomcat/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
rmaucher commented on PR #751:
URL: https://github.com/apache/tomcat/pull/751#issuecomment-2343329930
This looks to be more precise (so maybe ?) but the start of processing
and/or actual completion of requests on two separate connections is a rather
random affair timing wise. Anything can h
markt-asf commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754134779
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
rainerjung commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754287909
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
rainerjung commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754287909
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
rainerjung commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754287909
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
markt-asf merged PR #33:
URL: https://github.com/apache/tomcat-training/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.a
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1755922817
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
Chenjp commented on PR #750:
URL: https://github.com/apache/tomcat/pull/750#issuecomment-2345073418
> This PR will not be applied.
>
> `SynchronizedStack` is deliberately designed not to support shrinking the
stack because:
>
> * Tomcat doesn't need the capability to shrink
isapir commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756091747
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
isapir commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756091747
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756100613
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
isapir commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756107715
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756122503
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
markt-asf commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756307644
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -104,8 +104,9 @@ public final class FastHttpDateFormat {
*/
public static String getCurrent
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756465922
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -104,8 +104,9 @@ public final class FastHttpDateFormat {
*/
public static String getCurrentDat
PaulLodge opened a new pull request, #752:
URL: https://github.com/apache/tomcat/pull/752
This test adds code coverage for CVE-2010-3718, I noticed it was missing
from the code coverage, the fix also contains a very small code refactor that
allows the test to work.
--
This is an automate
n828cl commented on PR #752:
URL: https://github.com/apache/tomcat/pull/752#issuecomment-2346272595
The new method testRewriteEmptyHeader() does not appear to be invoked from
anywhere. Is some of the change missing?
--
This is an automated message from the Apache Git Service.
To respond t
dsoumis opened a new pull request, #753:
URL: https://github.com/apache/tomcat/pull/753
This is an effort of introducing Parameter Limit Valve to allow limiting the
number of parameters in HTTP requests, but explicitly allowing more parameters
for specific URLs.
It's worth to be note
rmaucher merged PR #752:
URL: https://github.com/apache/tomcat/pull/752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or
markt-asf commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1757204766
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -104,8 +104,9 @@ public final class FastHttpDateFormat {
*/
public static String getCurrent
markt-asf commented on PR #753:
URL: https://github.com/apache/tomcat/pull/753#issuecomment-2346801534
This approach could be implemented as a Filter. If we were going to do this,
I think something that enforces the limit at the point the parameters are
parsed - rather than after - is the w
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1758003371
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -104,8 +104,9 @@ public final class FastHttpDateFormat {
*/
public static String getCurrentDat
ChristopherSchultz commented on PR #752:
URL: https://github.com/apache/tomcat/pull/752#issuecomment-2349122345
> The new method testRewriteEmptyHeader() does not appear to be invoked from
anywhere. Is some of the change missing?
It's a unit test, called by the JUint test harness.
-
ChristopherSchultz commented on PR #753:
URL: https://github.com/apache/tomcat/pull/753#issuecomment-2349139662
While I haven't actually looked at the code (for either
`request.parseParameters` or this Valve), I thought the point of
`maxParameterCount` was that the request would actually fa
dsoumis commented on PR #753:
URL: https://github.com/apache/tomcat/pull/753#issuecomment-2352800101
I will refactor the implementation as follows:
1. The maxParameterCount limit will be enforced directly within
Request.doParseParameters(). If the Valve is set and the number of parameter
markt-asf commented on PR #751:
URL: https://github.com/apache/tomcat/pull/751#issuecomment-2352813882
The code looks good to me but I'd still like to see an answer to Rémy's
question above before we decide whether to merge this PR.
--
This is an automated message from the Apache Git Serv
rmaucher commented on PR #751:
URL: https://github.com/apache/tomcat/pull/751#issuecomment-2352839659
It it doesn't much perform worse, I'm fine with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
markt-asf commented on PR #753:
URL: https://github.com/apache/tomcat/pull/753#issuecomment-2352850075
> The parameter count limit is there to protect Tomcat from a DoS caused by
hash collisions (right?).
Hash collisions was why the 10k limit was put in place -
[CVE-2012-0022](http:/
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2408312003
Customize filter to skip remoteAddr obtain:
```java
package filters;
...
public class RateLimiterPerformanceFilter extends RateLimitFilter {
private Random random
emileplas opened a new pull request, #765:
URL: https://github.com/apache/tomcat/pull/765
https://bz.apache.org/bugzilla/show_bug.cgi?id=55470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Chenjp closed pull request #755: Fix: evict cached MBean when bean descriptor
content changed to ensure ManagedBean#getMBeanInfo result is correct.
URL: https://github.com/apache/tomcat/pull/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Chenjp commented on PR #755:
URL: https://github.com/apache/tomcat/pull/755#issuecomment-2410156261
No valid use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
ChristopherSchultz opened a new pull request, #761:
URL: https://github.com/apache/tomcat/pull/761
Use sendError(103) or setStatus(103).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2402893460
I noticed that `Response` does some things that `ResponseFacade` does not.
Specifically, it is sensitive to whether or not there is an *include* in
progress. However, if the `Resp
Chenjp commented on PR #757:
URL: https://github.com/apache/tomcat/pull/757#issuecomment-2401707085
new PR #760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Chenjp opened a new pull request, #760:
URL: https://github.com/apache/tomcat/pull/760
Original PR: https://github.com/apache/tomcat/pull/757
1. Accurate rate limiter.
2. exposeHeaders - disabled by default, for debugging purpose only.
3. Performance test shows
(org.apache.catalina
markt-asf commented on PR #758:
URL: https://github.com/apache/tomcat/pull/758#issuecomment-2402184594
From memory of previous discussions, implementing Request/Response wrapping
in Valves is non-trivial. I'd expose a setter for `requestId`.
--
This is an automated message from the Apache
markt-asf closed pull request #757: BZ69355: RateLimitFilter2 with
FixedWindowRateLimiter
URL: https://github.com/apache/tomcat/pull/757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markt-asf commented on PR #757:
URL: https://github.com/apache/tomcat/pull/757#issuecomment-2402040291
Closing in favour of new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
markt-asf commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2402047535
The performance results look odd to me. I'd expect throughput to be
significantly higher in all cases. I wonder if the request processing time is
dominating the results rather than any ove
markt-asf commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2402045763
Could the headers follow
https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message,
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2402162598
> Could the headers follow
https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers/ ?
Great! Will look into the spec and implement it tomorrow.
--
This is an automated
rmaucher commented on PR #763:
URL: https://github.com/apache/tomcat/pull/763#issuecomment-2406721195
Thanks. I rewrote this to avoid using files and JSP, but with the same
general idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rmaucher closed pull request #763: Test if a custom 404 page is configured but
the error jsp redirects to the project root
URL: https://github.com/apache/tomcat/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
PaulLodge opened a new pull request, #763:
URL: https://github.com/apache/tomcat/pull/763
This test covers the regression mentioned in https://svn.apache.org/r1830547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2405043622
> Oh, I see the code that you use to benchmark in the PR. Have you tried to
run an external tool like `ab` or `wrk2`?
@isapir thanks for your suggestion, will try run ab benchmark from
isapir commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2403736338
> In Performance Test, request client threads have sleep ops.
Why? Can those be removed?
> Average cost of each rateLimiter is about 3500ns. The difference in time
cost between F
helloliu01 opened a new pull request, #769:
URL: https://github.com/apache/tomcat/pull/769
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
funkman commented on PR #766:
URL: https://github.com/apache/tomcat/pull/766#issuecomment-2417380024
My bad - This was an old fork of master (started back on Jun 26, 2020) ,
then renamed to main to keep in sync that I assumed just clicking the "sync my
fork" would clear the history/clutter
ChristopherSchultz commented on PR #766:
URL: https://github.com/apache/tomcat/pull/766#issuecomment-2417293490
Something looks odd, here. Pull request #1 has a huge number of changes and
is a part of this PR, yet this PR says only one file changed.
The docs webapp should be self-cont
ChristopherSchultz closed pull request #766: Anchor fixes in docs
URL: https://github.com/apache/tomcat/pull/766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ChristopherSchultz commented on PR #766:
URL: https://github.com/apache/tomcat/pull/766#issuecomment-2417297756
Tim, if you want to remove the link, (a) just commit a single change
directly to main if you want or (b) create a PR from main and not from
patched-my-fork-from-main.
--
This i
spencekiddle opened a new pull request, #768:
URL: https://github.com/apache/tomcat/pull/768
Added default value for connectionUploadTimeout in the event that a value is
not provided and disableUploadTimeout is set to false.
--
This is an automated message from the Apache Git Service.
To
helloliu01 closed pull request #769: 10.0.x
URL: https://github.com/apache/tomcat/pull/769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
jengebr opened a new pull request, #770:
URL: https://github.com/apache/tomcat/pull/770
This change fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=69381 by
caching the JVM-provided `Method[]`. The OpenJDK compiler creates duplicate
`Method` objects on every call to `Class.getMethods(
rmaucher commented on PR #43:
URL:
https://github.com/apache/tomcat-maven-plugin/pull/43#issuecomment-2426478012
I could be talked into hitting the merge button. However, there is no way
I'll +1 this for a release, it needs a "full" rewrite.
--
This is an automated message from the Apach
rmaucher merged PR #768:
URL: https://github.com/apache/tomcat/pull/768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or
rmaucher commented on PR #43:
URL:
https://github.com/apache/tomcat-maven-plugin/pull/43#issuecomment-2418683831
There was some interest to revive the component. So this is a starting
point, thanks.
I would suggest:
- Drop 7 and 8 support since they are EOL.
- Test with a more rece
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2418961846
@markt-asf any news?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gilbertoca commented on PR #43:
URL:
https://github.com/apache/tomcat-maven-plugin/pull/43#issuecomment-2419333052
@rmaucher what about incorporate those changes, tag then for use only up to
jdk11 and Java EE 8, release as is?
So, after this, I will try to create a PR taking into account
Chenjp closed pull request #760: BZ69355: ExactRateLimiter
URL: https://github.com/apache/tomcat/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
Chenjp opened a new pull request, #767:
URL: https://github.com/apache/tomcat/pull/767
replace #760: redo pr , change src branche from "main" to a dedicated
branch "main_BZ69355".
for headers section, compliance with draft spec of
"https://datatracker.ietf.org/doc/draft-ietf-httpapi-rat
isapir commented on PR #762:
URL: https://github.com/apache/tomcat/pull/762#issuecomment-2403933166
Is there a reason you are using Tomcat 10.0 and not Tomcat 10.1? Tomcat
10.0 is no longer supported
See https://tomcat.apache.org/tomcat-10.0-eol.html
--
This is an automated messa
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2404718668
> > Could the headers follow
https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers/ ?
>
> Great! Will look into the spec and implement it tomorrow.
ratelimit-head
michael-o closed pull request #759: BZ 69370: DefaultServlet's HTML listing
uses incorrect labels
URL: https://github.com/apache/tomcat/pull/759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
michael-o commented on PR #759:
URL: https://github.com/apache/tomcat/pull/759#issuecomment-2404653354
Merged manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
rmaucher commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404535177
> Is there now static final for that status code?
Are you talking about
https://github.com/apache/tomcat/blob/main/java/jakarta/servlet/http/HttpServletResponse.java#L406
?
--
Thi
michael-o commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404594880
> > Is there now static final for that status code?
>
> Are you talking about
https://github.com/apache/tomcat/blob/main/java/jakarta/servlet/http/HttpServletResponse.java#L406
?
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405394259
I will also be adding at least one unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405393185
Tomcat 11 is based on Jakarta EE 11 which does not (yet) have this constant.
I originally wrote this patch just for Tomcat 11 but now that I think about
it, I think I should
ChristopherSchultz commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1795646509
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1069,16 +1069,20 @@ public void sendError(int status, String message)
throws IOException {
ChristopherSchultz closed pull request #761: Allow applications to trigger
sending of 103 early hints
URL: https://github.com/apache/tomcat/pull/761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405802038
I'm not great at github, so I ended up killing this branch and re-creating
it. I will have a follow-up PR soon.
--
This is an automated message from the Apache Git Service.
To r
1201 - 1300 of 2023 matches
Mail list logo
