dsoumis commented on PR #753:
URL: https://github.com/apache/tomcat/pull/753#issuecomment-2352800101
I will refactor the implementation as follows:
1. The maxParameterCount limit will be enforced directly within
Request.doParseParameters(). If the Valve is set and the number of parameters
exceeds the configured limit, the request will fail immediately, preventing
parameter parsing operations from taking place.
2. The ParameterLimitValve will only adjust the maxParameterCount on the
Request object before parameter parsing occurs. The actual enforcement of the
limit will remain in the parsing stage, ensuring that no recovery happens
post-parsing, and thus preserving the intended DoS protection.
Please let me know if this sounds like a reasonable solution, or if there’s
anything else to consider that I am missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
