isapir commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756091747
##########
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##########
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
- if (Math.abs(now - currentDateGenerated) > 1000) {
+ if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
Modulus is also a slow operation. If there is a chance of this slowing
every request by 1ms as @markt-asf suggested then I'm a `-1` on this. A `1ms`
slowdown could mean up to 1,000 less requests-per-second in throughput.
Any unnecessary change should be benchmarked to evaluate the overhead that
it adds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
