Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1755922817
##########
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##########
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
- if (Math.abs(now - currentDateGenerated) > 1000) {
+ if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
to minimize costs , ignore ms part to avoid divide ops:
```java
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Ignore millisecond part.
now -= now % 1000L;
// Handle case where time moves backwards (e.g. system time
corrected)
if (now != currentDateGenerated) {
currentDate = FORMAT_RFC5322.format(new Date(now));
currentDateGenerated = now;
}
return currentDate;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
