Chenjp commented on PR #750:
URL: https://github.com/apache/tomcat/pull/750#issuecomment-2345073418
> This PR will not be applied.
>
> `SynchronizedStack` is deliberately designed not to support shrinking the
stack because:
>
> * Tomcat doesn't need the capability to shrink the stack
>
> * shrinking the stack creates garbage and this class is intended to
avoid unnecessary garbage
Then method #setLimit should not be public:
```java
public class Http2Protocol implements UpgradeProtocol {
@Override
public void setHttp11Protocol(AbstractHttp11Protocol<?> http11Protocol) {
this.http11Protocol = http11Protocol;
recycledRequestsAndResponses.setLimit(http11Protocol.getMaxConnections());
```
@markt-asf What would happen if we reconfigure a stack(with 200 elements)
limitation from -1 to 100?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
