markt-asf commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1757204766
##########
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##########
@@ -104,8 +104,9 @@ public final class FastHttpDateFormat {
*/
public static String getCurrentDate() {
long now = System.currentTimeMillis();
- // Handle case where time moves backwards (e.g. system time corrected)
- if (Math.abs(now - currentDateGenerated) > 1000) {
+ // Ignore millisecond part.
+ now -= now % 1000L;
Review Comment:
That performance difference is pretty marginal but I do think division by
1000 is simpler code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
