Re: Difference in the behaviour of WebappClassLoaderBase.getResource for jar resources

2016-05-03 Thread Konstantin Kolinko
2016-05-03 17:07 GMT+03:00 Violeta Georgieva : > Hi, > > 2016-04-27 14:27 GMT+03:00 Konstantin Kolinko : >> >> 2016-04-27 14:00 GMT+03:00 Violeta Georgieva : >> > Hi, >> > >> > I have a question about difference in the behaviour of >> > org

Re: OpenSSL issues and release plans

2016-05-03 Thread Konstantin Kolinko
ip files, at native/srclib/VERSIONS in source archives) saying APR 1.5.1, while 1.5.2 was actually used. > If all goes to plan, we should have a 9.0.x release around the middle of > next week. Best regards, Konstantin Kolinko --

Re: Compiling JSPs with Jigsaw enabled Java 9

2016-05-18 Thread Konstantin Kolinko
bug in JRE 9. I think we use getResource() in Tomcat code to test existence of classes before trying to load them. Is evaluation of static methods / static fields working in EL (e.g. ${Integer.MAX_VALUE} Best regards, Konstantin Kolinko

Re: Regarding files generated by "JJTree"

2016-05-20 Thread Konstantin Kolinko
re is also documentation (xml -> html), javadoc (java -> html). The mailing list rules: http://tomcat.apache.org/lists.html#tomcat-users -> 6. Top-posting is bad. Best regards, Konstantin Kolinko - To unsubscribe, e-

Re: Timescale for 8.0.x EOL

2016-06-20 Thread Konstantin Kolinko
ong term support for our customers, one way is to >> keep 8.0.x alive here so the community can benefit our efforts. > > Since it seems there is some interest in maintaining 8.0.x beyond > September, how about we announce that: > - the monthly release cycle for 8.0.x will end i

Re: svn commit: r1751479 - in /tomcat/tc8.5.x/trunk: ./ bin/ conf/ java/org/apache/catalina/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/

2016-07-06 Thread Konstantin Kolinko
2016-07-05 16:59 GMT+03:00 : > Author: markt > Date: Tue Jul 5 13:59:14 2016 > New Revision: 1751479 > > URL: http://svn.apache.org/viewvc?rev=1751479&view=rev > Log: > Use UTF-8 with a standard prolog for all XML files. > > Modified: > tomcat/tc8.5.x/trunk/ (props changed) > tomcat/tc8

Re: [Tomcat Wiki] Update of "FrontPage" by KonstantinKolinko

2016-07-19 Thread Konstantin Kolinko
t; >> ##language:en >> = Welcome to the Apache Tomcat Wiki = >> - {{http://tomcat.apache.org/images/tomcat.gif}} >> + {{https://tomcat.apache.org/images/tomcat.gif}} > > Protocol relative //tomcat.apache.org/... > > Might

Re: UMASK issue after update from tomcat 8.0 to 8.5

2016-07-21 Thread Konstantin Kolinko
the full list of changes between 8.0.x and 8.5.0 you should see the Tomcat 9 changelog from bottom and up to 9.0.0.M4. The list of changes is long and some may have been unintentionally overlooked when authoring the guide. Best regards, Konstantin Kolinko --

Re: Request for Wiki karma

2016-07-24 Thread Konstantin Kolinko
2016-07-24 13:35 GMT+03:00 Felix Schumacher : > > Please add my id FelixSchumacher to the admin group, so that I could > accomplish such tasks in the future. Done. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

Re: Request for Wiki karma

2016-07-24 Thread Konstantin Kolinko
. My user name is GregTrasuk Done. Welcome! Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.71

2016-09-09 Thread Konstantin Kolinko
es work. I filed the details into Bugzilla: https://bz.apache.org/bugzilla/show_bug.cgi?id=60101 I think this is a showstopper. That said, this build is usable when SecurityManager is not enabled. Best regards, Konstantin Kolinko - To unsu

Re: svn commit: r1762955 - in /tomcat/tc8.0.x/trunk: ./ build.xml java/org/apache/naming/JndiPermission.java

2016-09-30 Thread Konstantin Kolinko
2016-09-30 22:38 GMT+03:00 : > Author: markt > Date: Fri Sep 30 19:38:36 2016 > New Revision: 1762955 > > URL: http://svn.apache.org/viewvc?rev=1762955&view=rev > Log: > Remove unused class now JNDI is no longer used for resource access 1. This class is still mentioned here, in Tomcat 8.0, in two

Re: svn commit: r1763403 - in /tomcat/tc8.5.x/trunk: ./ bin/ conf/ java/org/apache/catalina/webresources/ java/org/apache/catalina/webresources/war/ java/org/apache/tomcat/util/buf/ java/org/apache/to

2016-10-05 Thread Konstantin Kolinko
en running with a Security Manager, and policy file uses war: URLs)? 1. I am concerned about running Tomcat as service. (I do not see changes to tomcat.nsi and to service.bat here). 2. I am concerned about running Tomcat in Eclipse IDE. It runs as a java application (with a set of options

Re: [VOTE] JK 1.2.42 windows binaries debug symbols

2016-10-10 Thread Konstantin Kolinko
tomcat-connectors/jk/binaries/windows/symbols/ > > [ ] -1: Don't release because ... > [x] +1: Release Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tagging 9.0.x and friends

2017-03-08 Thread Konstantin Kolinko
build it, do not run any tests. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.76

2017-03-16 Thread Konstantin Kolinko
IO, Windows 10), with several known failures on Java 6, no changes here (TestHostConfigAutomaticDeployment x all, TestSsl x APR). Smoke testing OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.a

Re: Host header validation

2017-03-22 Thread Konstantin Kolinko
nd above is the formal syntax for it) IPvFuture address - I think it is too early to implement it, but it can be a reason to have a flag to turn off this check, An example of IPvFuture address with HTTPd, and its response (400): https://bz.apache.org/bugzilla/show_bug.cgi?id=55362 So apparently Apac

Odd behaviour of "deprecated" websocket API example - chat servlet - 7.0.77

2017-03-30 Thread Konstantin Kolinko
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1729) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnabl

Plans for 8.5.14 ?

2017-04-10 Thread Konstantin Kolinko
Hi! Is there a plan to tag 8.5.14, not waiting for May 1st? My concern is regression in Manager web application, https://bz.apache.org/bugzilla/show_bug.cgi?id=60949 Best regards, Konstantin Kolinko - To unsubscribe, e-mail

Re: svn commit: r1791050 - in /tomcat/trunk/java: javax/el/ javax/security/auth/message/config/ javax/websocket/ javax/websocket/server/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/c

2017-04-12 Thread Konstantin Kolinko
ECLARED)). Javadoc: http://docs.oracle.com/javase/7/docs/api/java/lang/Class.html The same for other changes in this commit. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.78

2017-05-16 Thread Konstantin Kolinko
a 6, 7, 8 - 32-bit JDK on Windows 10). Smoke testing OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: try to release taglibs-standard-1.2.6

2017-05-16 Thread Konstantin Kolinko
a pre_126_bz60950 tag instead. > Would that be acceptable ? I'd prefer more explicit "1.2.6" in the name. Maybe just name it a "release candidate", e.g.: https://svn.apache.org/repos/asf/tomcat/taglibs/s

Re: try to release taglibs-standard-1.2.6

2017-05-16 Thread Konstantin Kolinko
2017-05-16 16:44 GMT+03:00 Rémy Maucherat : > 2017-05-16 14:43 GMT+02:00 Konstantin Kolinko : > >> 2017-05-16 14:56 GMT+03:00 Rémy Maucherat : >> > 2017-04-30 11:10 GMT+02:00 jean-frederic clere : >> > >> >> Hi, >> >> >> >>

Re: Running Tomcat in an IDE

2017-05-29 Thread Konstantin Kolinko
2017-05-28 23:14 GMT+03:00 Igal @ Lucee.org : > I am trying to run Tomcat in IntelliJ IDEA. I have set up the project and > am able to build it and run it, but then I get runtime errors, e.g. > ClassNotFound (stack traces below). > > Is this a classpath issue or am I simply missing some environmen

Re: svn commit: r1771090 - in /tomcat/tc8.0.x/trunk: ./ build.properties.default build.xml webapps/docs/changelog.xml

2016-11-24 Thread Konstantin Kolinko
Hi! Note that such options are usually documented in BUILDING.txt (7) Tests (7.1) Running Tomcat tests (7.4) Other configuration options ... 2016-11-24 11:59 GMT+03:00 : > Author: violetagg > Date: Thu Nov 24 08:59:08 2016 > New Revision: 1771090 > > URL: http://svn.apache.org/viewvc?rev=177

Re: svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

2016-12-22 Thread Konstantin Kolinko
: http://tomcat.apache.org/whoweare.html Usually that is the first task for new committers. You are welcome. Best regards, Konstantin Kolinko 2016-12-21 22:05 GMT+03:00 Coty Sutherland : >> That reference is correct. Tomcat 9 implements specs from Java EE 8. > > Ah, I'll fix it.

Re: [VOTE] Release Apache Tomcat 7.0.74

2017-01-17 Thread Konstantin Kolinko
va 6/7/8 32-bit on Windows 10) Smoke testing OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1779249 - in /tomcat/site/trunk: docs/ xdocs/

2017-01-17 Thread Konstantin Kolinko
t; -compared to 8.5.8 include: > +compared to 8.5.9 include: All other places and files in this commit are OK. Missing doap_Tomcat.rdf, but 8.5 an 9.0 are not listed there (yet). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Need to consider a replacement for */ in WAR URLs

2017-01-17 Thread Konstantin Kolinko
3. We can use a delimiter that is longer than 2 characters. We are not limited to "char + '/'". 4. If the file part must refer an existing file, we can look for ".war/" incrementally and check whether it is an existing file. Though depending o

Re: [VOTE] Release Apache Tomcat 6.0.49

2017-01-18 Thread Konstantin Kolinko
se as 6.0.49 Stable The ASF logo image is missing (not displayed) in ROOT and host-manager web applications. It is displayed correctly in the manager application. Unit tests OK, the rest of smoke testing is OK. Best regards, Konstantin Kolinko ---

Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-20 Thread Konstantin Kolinko
weare.html See README.txt in the site source directory, https://svn.apache.org/repos/asf/tomcat/site/trunk/ Best regards, Konstantin Kolinko 2017-01-20 23:26 GMT+03:00 : > Author: ebourg > Date: Fri Jan 20 20:26:45 2017 > New Revision: 1779674 > > URL: http://svn.apache.org/viewvc?rev

Re: Memory leak found in java.util.concurrent.ForkJoinPool

2017-01-21 Thread Konstantin Kolinko
rg/bugzilla/show_bug.cgi?id=60620 As for Oracle bug number, I do not see this issue with a quick search at http://bugs.java.com/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-24 Thread Konstantin Kolinko
2017-01-23 11:38 GMT+03:00 Emmanuel Bourg : > Hi Konstantin, > > Le 21/01/2017 à 08:58, Konstantin Kolinko a écrit : > >> 1. Please update xdocs/miscellaneous/changelog.xml as well. > > Thanks I didn't see it. There is a bug number for this change, 60388. It is

Re: svn commit: r1780262 - /tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java

2017-01-25 Thread Konstantin Kolinko
th a single @Ignore'd method -> I remember that in such case the annotation had to be moved to class level. (I do not remember the reason, but I think that we will see it soon enough.) Best regards, Konstantin Kolinko > Added: > tomcat/trunk/test/org/apache/jasper/runtime/TestTagHand

Re: [VOTE] Release Apache Tomcat 6.0.50

2017-01-26 Thread Konstantin Kolinko
id=6427854 Smoke testing OK. Manager, Host Manager, Documentation - ASF icon is OK, issue was fixed. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 6.0.50

2017-01-26 Thread Konstantin Kolinko
mappedfile false http://tomcat.apache.org/tomcat-6.0-doc/jasper-howto.html I wonder whether the mentioned TCK test will pass with that option. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1781539 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2017-02-03 Thread Konstantin Kolinko
-1. Not equivalent. Boolean.java in 8u121: public static Boolean valueOf(String s) { return parseBoolean(s) ? TRUE : FALSE; } public static boolean parseBoolean(String s) { return ((s != null) && s.equalsIgnoreCase("true")); } It compares case-insensitively. Old

Re: InstanceListener, InstanceEvent: Unused?

2016-01-04 Thread Konstantin Kolinko
vletContext.addServlet(String, String, Servlet)), but in general one can implement a LifecycleListener and enumerate wrappers after a web application have started. The servlet instance can be obtained and replaced via StandardWrapper.getServlet()/setServlet(). I am OK with removal of InstanceL

Re: svn commit: r1723506 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2016-01-07 Thread Konstantin Kolinko
2016-01-07 13:19 GMT+03:00 : > Author: markt > Date: Thu Jan 7 10:19:14 2016 > New Revision: 1723506 > > URL: http://svn.apache.org/viewvc?rev=1723506&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58809 > Correctly recycle the cookies when mapping requests for parallel depl

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Konstantin Kolinko
on "START_EVENT" requires support of "2.a) - allow change at any time". I am OK with not allowing manager change on that event. I think implementing "1. no change" is not possible, because StandardContext.reload() method calls stop();

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Konstantin Kolinko
2016-01-08 20:26 GMT+03:00 Mark Thomas : > On 08/01/2016 16:56, Konstantin Kolinko wrote: >> 2016-01-08 15:33 GMT+03:00 Mark Thomas : >>> I've been looking at the relationship between a Context and its Manager >>> and I have identified some inconsistencies in t

Re: tagging tomcat 6.0.45

2016-01-08 Thread Konstantin Kolinko
i to skip Itanium binaries. Tomcat 7 has this issue as well. I am not sure that we want to ship it with native 1.1.33. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional co

Re: svn commit: r1723752 - in /tomcat/trunk/java/org/apache: catalina/filters/ catalina/ha/ catalina/ha/backend/ catalina/ha/deploy/ catalina/ha/session/ catalina/ha/tcp/ catalina/session/ catalina/tr

2016-01-08 Thread Konstantin Kolinko
tag. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-08 Thread Konstantin Kolinko
n.microsoft.com/en-us/library/yd4f8bd1%28v=vs.100%29.aspx [2] http://blogs.msdn.com/b/jimgries/archive/2007/07/06/why-does-visual-studio-require-debugger-symbol-files-to-exactly-match-the-binary-files-that-they-were-built-with.aspx Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-09 Thread Konstantin Kolinko
2016-01-08 23:41 GMT+03:00 Konstantin Kolinko : > 2016-01-08 12:58 GMT+03:00 Mark Thomas : >> On 08/01/2016 09:13, jean-frederic clere wrote: >>> On 01/06/2016 08:45 PM, Mark Thomas wrote: >>>> On 06/01/2016 19:34, Rainer Jung wrote: >>>>> Hi Mark, &

Re: dropping windows ia64 in Tomcat6

2016-01-10 Thread Konstantin Kolinko
2016-01-11 10:03 GMT+03:00 jean-frederic clere : > Hi, > > > I would like to drop Itanium support in the windows binaries, we have > dropped it in native 1.1.34 so we can't have a complete Itanium in > Tomcat 6.0.45. +1. Best rega

Tomcat CWiki commit notifications missing

2016-01-11 Thread Konstantin Kolinko
Hi! Does Confluence wiki at [1] generate commit notification e-mails? None of those are received by dev@tomcat list. [1] https://cwiki.apache.org/confluence/display/TOMCAT/ Best regards, Konstantin Kolinko - To unsubscribe

Re: Tomcat CWiki commit notifications missing

2016-01-12 Thread Konstantin Kolinko
2016-01-11 14:47 GMT+03:00 Mark Thomas : > On 11/01/2016 11:38, Mark Thomas wrote: >> On 11/01/2016 11:04, Konstantin Kolinko wrote: >>> Hi! >>> >>> Does Confluence wiki at [1] generate commit notification e-mails? >> >> I think we'll need to cr

Re: Tomcat CWiki commit notifications missing

2016-01-12 Thread Konstantin Kolinko
2016-01-12 14:51 GMT+03:00 Mark Thomas : > On 12/01/2016 11:37, Konstantin Kolinko wrote: >> 2016-01-11 14:47 GMT+03:00 Mark Thomas : >>> On 11/01/2016 11:38, Mark Thomas wrote: >>>> On 11/01/2016 11:04, Konstantin Kolinko wrote: >>>>> Hi! >>&g

Re: Tomcat CWiki commit notifications missing

2016-01-12 Thread Konstantin Kolinko
2016-01-12 15:27 GMT+03:00 Mark Thomas : > On 12/01/2016 12:17, Konstantin Kolinko wrote: >> 2016-01-12 14:51 GMT+03:00 Mark Thomas : >>> On 12/01/2016 11:37, Konstantin Kolinko wrote: >>>> 2016-01-11 14:47 GMT+03:00 Mark Thomas : >>>>> On 11/01/2016 1

Re: svn commit: r1724437 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationHttpRequest.java webapps/docs/changelog.xml

2016-01-13 Thread Konstantin Kolinko
2016-01-13 18:02 GMT+03:00 : > Author: markt > Date: Wed Jan 13 15:02:00 2016 > New Revision: 1724437 > > URL: http://svn.apache.org/viewvc?rev=1724437&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58836 > Correctly merge query string parameters when processing a forwarded r

Re: svn commit: r1724437 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationHttpRequest.java webapps/docs/changelog.xml

2016-01-14 Thread Konstantin Kolinko
2016-01-14 11:43 GMT+03:00 Mark Thomas : > On 14/01/2016 03:08, Konstantin Kolinko wrote: >> 2016-01-13 18:02 GMT+03:00 : >>> Author: markt >>> Date: Wed Jan 13 15:02:00 2016 >>> New Revision: 1724437 > >> Looking into Parameters.handleQueryParameter

Re: svn commit: r1725706 - /tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java

2016-01-20 Thread Konstantin Kolinko
perform logging. TCCL is needed for that. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[RFC] Merge Tomcat 6 testing branch ()tomcat6-testing_20160106) into Tomcat 6

2016-01-21 Thread Konstantin Kolinko
/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [RFC] Merge Tomcat 6 testing branch ()tomcat6-testing_20160106) into Tomcat 6

2016-01-22 Thread Konstantin Kolinko
2016-01-22 16:08 GMT+03:00 Mark Thomas : > On 21/01/2016 22:15, Konstantin Kolinko wrote: >> Hi! >> >> 1. A branch that implements testting framework for Tomcat 6 is ready for >> review. >> It implements client-server unit tests (Tomcat, TomcatBaseTest classes) &

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-24 Thread Konstantin Kolinko
endencies) b) allows a performance improvement, as the search for those classes in web application classloader can be skipped Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1726672 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

2016-01-25 Thread Konstantin Kolinko
Testcase: testGetURLs took 0.758 sec Testcase: testFilter took 0.004 sec FAILED Class 'javax.security.auth.message.some.package.Example' failed deny filter junit.framework.AssertionFailedError: Class 'javax.security.auth.message.some.package.Example' failed deny filter at org.apache.catalina.loader.TestWebappClassLoader.testFilter(TestWebappClassLoader.java:137) ]]] Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1727355 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

2016-01-28 Thread Konstantin Kolinko
2016-01-28 17:04 GMT+03:00 : > Author: markt > Date: Thu Jan 28 14:04:00 2016 > New Revision: 1727355 > > URL: http://svn.apache.org/viewvc?rev=1727355&view=rev > Log: > Switch OutputBuffer to a local Map of C2BConvertors. Loading testing with > HTTP/2 and default Tomcat home page suggests an imp

Re: svn commit: r1727355 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

2016-01-28 Thread Konstantin Kolinko
2016-01-28 17:53 GMT+03:00 Mark Thomas : > On 28/01/2016 14:16, Konstantin Kolinko wrote: >> 2016-01-28 17:04 GMT+03:00 : >>> Author: markt >>> Date: Thu Jan 28 14:04:00 2016 >>> New Revision: 1727355 >>> >>> URL: http://svn.apache.org/viewvc

Re: svn commit: r1727355 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

2016-01-28 Thread Konstantin Kolinko
2016-01-28 20:22 GMT+03:00 Mark Thomas : > On 28 January 2016 15:11:03 GMT+00:00, "Rémy Maucherat" > wrote: >>2016-01-28 15:53 GMT+01:00 Mark Thomas : >> >>> On 28/01/2016 14:16, Konstantin Kolinko wrote: >> >> I have always used local encode

Re: Timing for 9.0.0.M3

2016-01-29 Thread Konstantin Kolinko
.0.M3 tomorrow morning. Once that release vote is ready to go, I'll > start on 8.0.x. I think redirection fail logging issue needs to be addressed https://bz.apache.org/bugzilla/show_bug.cgi?id=58768 It was asked on the mailing list twice. Reminding, so it does not fall off

Re: tagging tomcat 6.0.45 (try2)

2016-01-30 Thread Konstantin Kolinko
che.org/bugzilla/show_bug.cgi?id=58817 has not been fixed yet. I'll work on it today. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Request

2016-01-31 Thread Konstantin Kolinko
]] and [[[ package javax.servlet.http; public interface HttpServletRequest extends ServletRequest { ]]] If we are talking about other class [[[ package org.apache.coyote; public final class Request { ]]] It is final and no other implementations are allow

Re: tagging tomcat 6.0.45 (try2)

2016-01-31 Thread Konstantin Kolinko
2016-01-30 15:54 GMT+03:00 Konstantin Kolinko : > 2016-01-29 18:50 GMT+03:00 jean-frederic clere : >> Hi, >> >> I am planning to test and tag tomcat 6.0.45 during the week-end. >> >> Mark has fixed his session stuff and the openssl we use isn't affected >&

Re: ELParser fiel of type LookaheadSuccess extends Error

2016-02-04 Thread Konstantin Kolinko
method, b) preload the class. If we patch, we can also do so without regenerating the code. A well known place that preloads classes is org.apache.jasper.security.SecurityClassLoad class, but it preloads classes only when SecurityManager is present. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1730552 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2016-02-15 Thread Konstantin Kolinko
not currently sure why it doesn't work. >> Ideas welcome. > > Bingo. It doesn't work when testing of the local file system. Just need > to clean the layout up and I'll have this ready to go. I am -1 for these buttons as they may collect statistics of

Re: Files to exclude from buildbot rat tests

2016-02-16 Thread Konstantin Kolinko
me blocks of binary data - For Tomcat 9 those binary blocks are header samples from *.dia files, e.g. [[[ ]]] For Tomcat 8 there are samples from *.bmp files as well. The rat-output.xml file for Tomcat 9 does not have string ".bmp&qu

Re: Files to exclude from buildbot rat tests

2016-02-16 Thread Konstantin Kolinko
2016-02-16 12:40 GMT+03:00 Konstantin Kolinko : > 2016-02-16 0:15 GMT+03:00 Mark Thomas : >> On 15/02/2016 08:04, Gav wrote: >>> HI All, >>> >>> markt has added some exclusions recently that are preventing a successful >>> rat run on buildbot. >>

Re: Context path: any technical reason to ignore it?

2016-02-18 Thread Konstantin Kolinko
Deployment is protected by a lock keyed by web application name or path. Look for "serviced", "isServiced". Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

TestSendFile.NIO is failing in Tomcat 8

2016-02-19 Thread Konstantin Kolinko
100 bytes in 10 ms. - --- I guess something is wrong with recent processor recycle fix (I have not reviewed it yet). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r1731953 - in /tomcat/trunk: build.properties.default webapps/docs/changelog.xml

2016-02-23 Thread Konstantin Kolinko
dows users rarely visit the %USERPROFILE% directory. If we keep it in ${user.home} then maybe one of these names: ${user.home}/tomcat-lib-temp ${user.home}/tomcat-build-libs but maybe relative to the source directory, e.g. ../libraries, or libraries (in the source tree + svn:ignore, gitignore it)

Re: svn commit: r1733077 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/catalina/webresources/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat/util/scan/ webapps/docs/

2016-03-01 Thread Konstantin Kolinko
2016-03-01 17:20 GMT+03:00 : > Author: markt > Date: Tue Mar 1 14:20:56 2016 > New Revision: 1733077 > > URL: http://svn.apache.org/viewvc?rev=1733077&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59001 > Correctly handle the case when Tomcat is installed on a path where on

Re: svn commit: r1733077 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/catalina/webresources/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat/util/scan/ webapps/docs/

2016-03-01 Thread Konstantin Kolinko
2016-03-01 17:20 GMT+03:00 : > Author: markt > Date: Tue Mar 1 14:20:56 2016 > New Revision: 1733077 > > URL: http://svn.apache.org/viewvc?rev=1733077&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59001 > Correctly handle the case when Tomcat is installed on a path where on

Re: Tomcat 8.next

2016-03-02 Thread Konstantin Kolinko
is not documented at all. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1733617 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationPart.java webapps/docs/changelog.xml

2016-03-04 Thread Konstantin Kolinko
2016-03-04 20:24 GMT+03:00 : > Author: markt > Date: Fri Mar 4 17:24:36 2016 > New Revision: 1733617 > > URL: http://svn.apache.org/viewvc?rev=1733617&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59115 > When using the Servlet 3.0 file upload, the submitted file name may b

Re: Tomcat 8.next

2016-03-09 Thread Konstantin Kolinko
2016-03-02 16:42 GMT+03:00 Rémy Maucherat : > 2016-03-02 13:15 GMT+01:00 Konstantin Kolinko : >> >> >> 2. The feature of auto-switching sslImplementationName with >> availability of TCNative library needs better documentation. I suspect >> that it may c

Re: svn commit: r1734418 - in /tomcat/trunk: java/javax/servlet/jsp/el/ScopedAttributeELResolver.java java/org/apache/el/parser/AstIdentifier.java webapps/docs/changelog.xml

2016-03-10 Thread Konstantin Kolinko
2016-03-10 17:22 GMT+03:00 : > Author: markt > Date: Thu Mar 10 14:22:51 2016 > New Revision: 1734418 > > URL: http://svn.apache.org/viewvc?rev=1734418&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57583 > Improve long standing performance issue with EL and undefined attribu

Re: svn commit: r1734418 - in /tomcat/trunk: java/javax/servlet/jsp/el/ScopedAttributeELResolver.java java/org/apache/el/parser/AstIdentifier.java webapps/docs/changelog.xml

2016-03-10 Thread Konstantin Kolinko
2016-03-10 19:45 GMT+03:00 Mark Thomas : > On 10/03/2016 15:02, Konstantin Kolinko wrote: >> 2016-03-10 17:22 GMT+03:00 : >>> Author: markt >>> Date: Thu Mar 10 14:22:51 2016 >>> New Revision: 1734418 >>> >>> URL: http://svn.apache.

Re: svn commit: r1734592 - /tomcat/trunk/java/javax/el/ImportHandler.java

2016-03-11 Thread Konstantin Kolinko
2016-03-11 19:54 GMT+03:00 : > Author: markt > Date: Fri Mar 11 16:54:04 2016 > New Revision: 1734592 > > URL: http://svn.apache.org/viewvc?rev=1734592&view=rev > Log: > Speed up ImportHandler some more. > > Modified: > tomcat/trunk/java/javax/el/ImportHandler.java > > Modified: tomcat/trunk/j

Re: Mime types

2018-10-31 Thread Konstantin Kolinko
ive is disabled by default. http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/conf/httpd.conf.in?view=markup#l330 Performance =? The documentation of mod_mime_magic says that performance is a concern for this module. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Konstantin Kolinko
to Git someday, you are likely to use Git for Windows on that machine anyway). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1848225 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoaderBase.java WebappLoader.java

2018-12-07 Thread Konstantin Kolinko
is somewhat logging related so that > >> doesn't seem completely crazy. > >> > > > > Ok, why not. > > Apart from the fact it would mean touching almost every class in Tomcat? > > Seriously, the more I think about it the more I like it. M

Re: svn commit: r1811200 - in /tomcat/trunk/java/org/apache/juli: ClassLoaderLogManager.java FileHandler.java logging/DirectJDKLog.java

2017-10-05 Thread Konstantin Kolinko
See "Re:r1791050" thread, 12 Apr 2017. You should use getConstructor() here! Methods newInstance(), getConstructor() use a public constructor, but getDeclared*() may return a non-public method and using it requires additional privileges (checkMemberAccess(this, Member.DECLARED)). Javadoc: http:/

Re: svn commit: r1811704 - in /tomcat/trunk: java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2017-10-10 Thread Konstantin Kolinko
The HTMLManagerServlet class in the same package calls RequestUtil.filter() e.g. for web application names. (import org.apache.catalina.util.RequestUtil;) This class should use that method as well. There is no need to copy the implementation. 2017-10-10 17:22 GMT+03:00 : > Author: remm > Date:

Re: Multi-release Jars

2017-10-11 Thread Konstantin Kolinko
les (or multiple projects) to switch between the different > versions. > > I do like the reduction in code and the build script complexity doesn't > concern me overly - it is mostly adding volume rather than an complex > logic. The IDE issues are more annoying. I agree with the

Re: svn commit: r1812489 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ java/org/apache/catalina/servlets/ java/org/ap

2017-10-18 Thread Konstantin Kolinko
i); > +if (c == '<') { > +sb.append("<"); > +} else if (c == '>') { > +sb.append(">"); > +} else if (c == '\'') { > +sb.append("'"); > +} else if (c == '&') { > +sb.append("&"); > +} else if (c == '"') { > +sb.append("""); > +} else if (escapeCRLF && c == '\r') { > +sb.append(" "); > +} else if (escapeCRLF && c == '\n') { > +sb.append(" "); > +} else { > +sb.append(c); > +} > +} > + > +return sb.toString(); Maybe sb.length() > content.length() ? sb.toString() : content > +} > +} Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Konstantin Kolinko
2017-10-30 17:28 GMT+03:00 Mark Thomas : > On 30/10/17 14:18, Gary Gregory wrote: >> Hi All, >> >> It appears that Apache Commons RDF 0.4.0 has been released into the wild >> (our Maven repo AND Maven Central) without approval by the Apache Commons >> PMC. > > Do we know how that happened? > > The

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-11 Thread Konstantin Kolinko
n Tomcat 7 we have "java.7.home". The idea is to add explicit "java.6.home" along that. http://markmail.org/message/6qck3d4zqb6nh5ja Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-13 Thread Konstantin Kolinko
ends in writing asserts are to use assertThat + Hamcrest library matcher, and they look better with static imports. https://github.com/junit-team/junit4/wiki/matchers-and-assertthat Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1815208 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml

2017-11-14 Thread Konstantin Kolinko
on of a SHA-256 hash for release artefacts to the build s/generatation/generation Last time I was reading ASF documentation on releases, SHA-512 was the recommended sha2 length. http://www.apache.org/dev/release-signing.html#sha-checksum http://www.apache.org/dev/release-signing.html#sha1 A wel

Re: svn commit: r1815451 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioBlockingSelector.java java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2017-11-16 Thread Konstantin Kolinko
2017-11-16 16:30 GMT+03:00 : > Author: markt > Date: Thu Nov 16 13:30:26 2017 > New Revision: 1815451 > > URL: http://svn.apache.org/viewvc?rev=1815451&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61736 > Improve performance of NIO connector when clients leave large time ga

Re: svn commit: r1815571 - /tomcat/native/trunk/

2017-11-17 Thread Konstantin Kolinko
ct or project template for Tomcat Native, I agree that creating a new one by default will use the "bin" directory. Thus no real objections here. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1815568 - /tomcat/jk/trunk/xdocs/webserver_howto/iis.xml

2017-11-17 Thread Konstantin Kolinko
t; + > + > +Restart IIS (stop + start the IIS service). > + > + > + > + > +That's all, you should now start Tomcat and ask IIS to serve you the > /examples > +context. Try href="http://localhost/examples/";>http://localhost/examples/ > +for example and execute some of the Servlet or JSP examples. > > > +If this does not work successfully, refer to the Troubleshooting section > below for help on correcting the problem. > + > + Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1816043 - in /tomcat/jk/trunk/native: BUILDING.txt configure.ac

2017-11-22 Thread Konstantin Kolinko
2017-11-22 15:06 GMT+03:00 : > Author: markt > Date: Wed Nov 22 12:06:41 2017 > New Revision: 1816043 > > URL: http://svn.apache.org/viewvc?rev=1816043&view=rev > Log: > Remove apache-1.3 references > > Modified: > tomcat/jk/trunk/native/BUILDING.txt > tomcat/jk/trunk/native/configure.ac >

Re: svn commit: r1816247 - in /tomcat/trunk/java/org/apache/catalina/servlets: DefaultServlet.java WebdavServlet.java

2017-11-24 Thread Konstantin Kolinko
eserialization won't be followed by an init() call.) See https://docs.oracle.com/javase/7/docs/api/java/io/Serializable.html > /** > * If a file has a BOM, should that be used in preference to > fileEncoding? > The second half of this commit (WebdavServlet) is OK. Best re

Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-27 Thread Konstantin Kolinko
it "support" as "can run" only? > > Romain Manni-Bucau > @rmannibucau | Blog | Old Blog | Github | LinkedIn Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1816544 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java

2017-11-28 Thread Konstantin Kolinko
gt; > The old value looked better. It would be safer to use \u for non-ASCII characters in strings to avoid depending on IDE encoding preference. (\u00A3 for the pound currency character here.) Though it is likely that we have already used UTF-8 chars elsewhere. >> tomcat.addUser(utf

Re: [VOTE] Release Apache Tomcat 8.5.24

2017-11-28 Thread Konstantin Kolinko
ow, (sometimes <1KB/s)... Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1816617 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/mapper/ java/org/apache/catalina/startup/ java/org/apache/tomcat/util/des

2017-11-29 Thread Konstantin Kolinko
te on Host rather that a system property. (Though as I wrong above, I think we do not need to implement it). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tagging Tomcat 7/8.0

2017-11-30 Thread Konstantin Kolinko
ent BZ 57866 (use GZIPOutputStream provided by JDK on Java 7+) to workaround bug in Java 8u151/152 (BZ 61660). https://bz.apache.org/bugzilla/show_bug.cgi?id=57866 https://bz.apache.org/bugzilla/show_bug.cgi?id=61660 Best regards, K

<    9   10   11   12   13   14   15   16   17   18   >