Hi! Welcome! 1. Please update xdocs/miscellaneous/changelog.xml as well.
2. I see that other "able-" flags use AS_HELP_STRING() macro to format help string. Maybe use it here as well? 3. Don't forget to add youself to the list at Tomcat site http://tomcat.apache.org/whoweare.html See README.txt in the site source directory, https://svn.apache.org/repos/asf/tomcat/site/trunk/ Best regards, Konstantin Kolinko 2017-01-20 23:26 GMT+03:00 <ebo...@apache.org>: > Author: ebourg > Date: Fri Jan 20 20:26:45 2017 > New Revision: 1779674 > > URL: http://svn.apache.org/viewvc?rev=1779674&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60388 > Ensure --disable-maintainer-mode doesn't enable the maintainer mode > > Modified: > tomcat/native/trunk/native/configure.in > > Modified: tomcat/native/trunk/native/configure.in > URL: > http://svn.apache.org/viewvc/tomcat/native/trunk/native/configure.in?rev=1779674&r1=1779673&r2=1779674&view=diff > ============================================================================== > --- tomcat/native/trunk/native/configure.in (original) > +++ tomcat/native/trunk/native/configure.in Fri Jan 20 20:26:45 2017 > @@ -198,12 +198,16 @@ AC_ARG_ENABLE( > maintainer-mode, > [ --enable-maintainer-mode Turn on debugging and compile time warnings], > [ > - if test "$GCC" = "yes"; then > - CFLAGS="${CFLAGS} -DDEBUG -Wall" > - else > - CFLAGS="${CFLAGS} -DDEBUG" > - fi > -AC_MSG_RESULT([...Enabling Maintainer mode...]) > + case "${enableval}" in > + yes ) > + if test "$GCC" = "yes"; then > + CFLAGS="${CFLAGS} -DDEBUG -Wall" > + else > + CFLAGS="${CFLAGS} -DDEBUG" > + fi > + AC_MSG_RESULT([...Enabling Maintainer mode...]) > + ;; > + esac > ]) > > dnl > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
