2016-02-16 0:15 GMT+03:00 Mark Thomas <ma...@apache.org>: > On 15/02/2016 08:04, Gav wrote: >> HI All, >> >> markt has added some exclusions recently that are preventing a successful >> rat run on buildbot. > > Huh? You told me it was failing and asked me to exclude some files. > >> (More accurately the xml file produced is malformed due to inclusions of >> bad headers) >> >> Here are what I can see as the remaining invalid files; adding these to the >> rat-excludes file should enable a succesful run for tomcat 7,8 and trunk >> (9). >> >> >> tomcat-7-trunk - output/dist/src/res/side_left.bmp > > Added **/*.bmp > >> tomcat-7-trunk - >> output/dist/src/webapps/docs/tribes/leader-election-message-arrives.dia > > Added **/*.dia > >> tomcat-trunk - output/dist/side_left.bmp > > Already excluded but I extended to to **/*.bmp
Re: http://svn.apache.org/viewvc?rev=1730614&view=rev 1. Only Tomcat 7 and Tomcat 9 configurations were updated, but not Tomcat 8. 2. I see that the "**/*.bmp" pattern does work. (I feared that it does not.) As such, our rat-excludes.txt files can be simplified a lot. 3. Steps to reproduce the original problem: I do not see any failures being reported by Buildbot ([1] -> tomcat-trunk -> build number -> "shell_5 RAT Report Complete" step) neither before nor after the change, but the issue that Gav reported here can be observed manually by the following steps: - Go to http://tomcat.apache.org/ci.html#Buildbot [1] -> "Published files" link - Download rat-output.xml - Try to open it in a web browser (or XML editor). The file is malformed. - If you view through the file, there are some blocks of binary data - For Tomcat 9 those binary blocks are header samples from *.dia files, e.g. [[[ <resource name='/home/buildslave32/slave32/tomcat-trunk/build/output/dist/src/webapps/docs/tribes/leader-election-initiate-election.dia'><header-sample> ]]] For Tomcat 8 there are samples from *.bmp files as well. The rat-output.xml file for Tomcat 9 does not have string ".bmp" in it, but Tomcat 8 one has it. So the exclusion pattern **/*.bmp used in Tomcat 9 works successfully. [1] http://tomcat.apache.org/ci.html#Buildbot Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
