2017-01-23 11:38 GMT+03:00 Emmanuel Bourg <ebo...@apache.org>:
> Hi Konstantin,
>
> Le 21/01/2017 à 08:58, Konstantin Kolinko a écrit :
>
>> 1. Please update xdocs/miscellaneous/changelog.xml as well.
>
> Thanks I didn't see it.
There is a bug number for this change, 60388. It is better to mention
it as <bug>60388</bug>:
>> 2. I see that other "able-" flags use AS_HELP_STRING() macro to format
>> help string.
>>
>> Maybe use it here as well?
>
> I got a look and they seem fine since they already use ${enableval}.
The code and use of ${enableval} is OK. I mean the help string that
accompanies this option.
In other cases the help is formatted with AS_HELP_STRING() . In this
case it is just plain text formatted with sequences of whitespace
characters.
>> 3. Don't forget to add youself to the list at Tomcat site
>> http://tomcat.apache.org/whoweare.html
>>
>> See README.txt in the site source directory,
>> https://svn.apache.org/repos/asf/tomcat/site/trunk/
>
> Done.
Thanks. But you did not run Apache Ant (that performs XSLT and
generates the files in /docs directory).
Once you run it and commit the changed /docs/whoweare.html file, in
a few minutes it will be visible on the live site:
http://tomcat.apache.org/whoweare.html
(You may need to hit refresh / F5 key in your browser to see the changes).
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
