2016-01-22 16:08 GMT+03:00 Mark Thomas <ma...@apache.org>: > On 21/01/2016 22:15, Konstantin Kolinko wrote: >> Hi! >> >> 1. A branch that implements testting framework for Tomcat 6 is ready for >> review. >> It implements client-server unit tests (Tomcat, TomcatBaseTest classes) >> It implements running the tests with Apache Ant. >> >> The branch is here: >> https://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tomcat6-testing_20160106 >> >> Status summary and diff file are >> BRANCH-README.txt >> BRANCH-diff.diff >> >> If anybody want to comment/review before me merging this into >> tc6.0.x/trunk, you are welcome. > > Looks good to me. Minimal impact on existing code and anything that > expands on the tests we have in 6.0.x has to be a good thing. > > What are your plans for the large chunks of commented out code? Leave > them as is, remove them, something else?
Thank you for review. I plan to leave those chunks as is (commented-out). Some may be used /uncommented in the future. Some chunks have comment above them saying that this feature is not available in Tomcat 6 (may be implemented later). Some chunks are deprecated code (e.g. support for default Realm). Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
