Re: Review Request 56396: Refactor test rules

@After near the top of the class. From the diffs, it looks like SecurityClusterConfigDUnitTest has an @After at the very end. - Kevin Duling On Feb. 7, 2017, 9:28 a.m., Jinmei Liao wrote: > > --- > This is an automatically generat

Re: Review Request 56425: GEODE-2272: do not use a new method to start locator with pulse

working directory is "/tmp". The call to `File(".").getParentFile().getParentFile()` will return null. - Kevin Duling On Feb. 7, 2017, 7:03 p.m., Jinmei Liao wrote: > > --- > This is an automatically gene

Re: Review Request 56425: GEODE-2272: do not use a new method to start locator with pulse

> On Feb. 8, 2017, 9:02 a.m., Kevin Duling wrote: > > `File.getParentFile()` may return null. For example, assume your working > > directory is "/tmp". The call to > > `File(".").getParentFile().getParentFile()` will return null. > > Jared S

Review Request 56459: GEODE-2247: GFSH connect over HTTP without credentials should fail earlier

/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java fa052489772e3e03eb865d17dbbcb7e227813c42 Diff: https://reviews.apache.org/r/56459/diff/ Testing --- Log of UX on https://issues.apache.org/jira/browse/GEODE-2247 precheckin running Thanks, Kevin Duling

Re: Review Request 56459: GEODE-2247: GFSH connect over HTTP without credentials should fail earlier

-2247 precheckin running Thanks, Kevin Duling

Re: Review Request 56514: GEODE-2455: change test to use AssertJ assertThatThrownBy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56514/#review164996 --- Ship it! Ship It! - Kevin Duling On Feb. 9, 2017, 11:44 a.m

Re: Review Request 56516: GEODE-2456: change JUnit4CacheTestCase tearDown to use deleteQuietly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56516/#review164999 --- Ship it! Ship It! - Kevin Duling On Feb. 9, 2017, 12:06 p.m

Re: Review Request 56459: GEODE-2247: GFSH connect over HTTP without credentials should fail earlier

) --- Log of UX on https://issues.apache.org/jira/browse/GEODE-2247 precheckin successful Thanks, Kevin Duling

Re: Review Request 56519: GEODE-2458: await expected JMX notifications in verifyMemberNotifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56519/#review165025 --- Ship it! Ship It! - Kevin Duling On Feb. 9, 2017, 3:02 p.m

Re: Review Request 56520: Update dependency versions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165028 --- Ship it! Ship It! - Kevin Duling On Feb. 9, 2017, 4:07 p.m

Re: Review Request 56522: GEODE-2198: do not import cluster config if any region exists to prevent different servers having conflicing region definitions at one point of time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56522/#review165050 --- Ship it! Ship It! - Kevin Duling On Feb. 9, 2017, 4:57 p.m

Re: Review Request 56556: GEODE-2454: use DistributedMember.getId() for memberId assertions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56556/#review165158 --- Ship it! Ship It! - Kevin Duling On Feb. 10, 2017, 11:30

Re: Review Request 56586: GEODE-1716: refactor JMXMBeanDunitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56586/#review165367 --- Ship it! Ship It! - Kevin Duling On Feb. 12, 2017, 8:07 p.m

Re: Review Request 56668: GEODE-2474: mark NetstatDUnitTest as flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56668/#review165730 --- Ship it! Ship It! - Kevin Duling On Feb. 14, 2017, 9:01 a.m

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56637/#review165731 --- Ship it! Ship It! - Kevin Duling On Feb. 14, 2017, 11 a.m

Re: Review Request 56635: GEODE-2481: extract default properties generation to its own class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56635/#review165732 --- Ship it! Ship It! - Kevin Duling On Feb. 13, 2017, 6:33 p.m

Re: Review Request 56734: GEODE-2474: refactor code to use SystemUtils to read OS system props

? - Kevin Duling On Feb. 15, 2017, 4:23 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

Thanks, Kevin Duling

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56801/#review165975 ------- On Feb. 17, 2017, 1:09 p.m., Kevin Duling wrote: > > --- > This

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

.java 4620f1deb03b76452df3a8d95daf4294573f02b0 Diff: https://reviews.apache.org/r/56801/diff/ Testing --- precheckin running Thanks, Kevin Duling

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

4620f1deb03b76452df3a8d95daf4294573f02b0 Diff: https://reviews.apache.org/r/56801/diff/ Testing --- precheckin running Thanks, Kevin Duling

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

/ Testing (updated) --- precheckin successful Thanks, Kevin Duling

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

after that. geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java (lines 47 - 55) <https://reviews.apache.org/r/56991/#comment238602> Incomplete javadoc. It should be either filled out or omitted. - Kevin Duling On Feb. 23, 2017, 10:01 a.m.,

Locators with --bind-address

When starting a locator, gfsh has the --bind-address option to tie to a particular NIC. E.g., start locator --name=loc-sec --security-properties-file=./security.properties --classpath=/Users/kduling/gfsh-security --bind-address=localhost This address is the one the server uses to connect with.

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166761 --- Ship it! Ship It! - Kevin Duling On Feb. 24, 2017, 1:37 p.m

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57175/#review167291 --- Ship it! Ship It! - Kevin Duling On Feb. 28, 2017, 5:39 p.m

Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

/diff/1/ Testing --- precheckin running Thanks, Kevin Duling

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

eviews.apache.org/r/57208/#review167411 --- On March 1, 2017, 9:56 a.m., Kevin Duling wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57208/ > -

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

Diff: https://reviews.apache.org/r/57208/diff/2/ Changes: https://reviews.apache.org/r/57208/diff/1-2/ Testing --- precheckin running Thanks, Kevin Duling

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57221/#review167606 --- Ship it! Ship It! - Kevin Duling On March 1, 2017, 2:25 p.m

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/#review167696 --- Ship it! Ship It! - Kevin Duling On March 2, 2017, 7:30 a.m

Re: Review Request 57249: GEODE-2488: Remove lsof from netstat command tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57249/#review167718 --- Ship it! Ship It! - Kevin Duling On March 2, 2017, 11:12

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/#review167900 --- Ship it! Ship It! - Kevin Duling On March 3, 2017, 2:17 p.m

Re: Review Request 57311: GEODE-2593: add port range to AvailablePortHelper to fix testUDPPortRange

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57311/#review167987 --- Ship it! Ship It! - Kevin Duling On March 3, 2017, 5:57 p.m

Re: Review Request 57342: GEODE-2267: mark local time sensitive tests as flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57342/#review168035 --- Ship it! Ship It! - Kevin Duling On March 6, 2017, 9:03 a.m

Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

` Thanks, Kevin Duling

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57390/#review168170 ------- On March 7, 2017, 9:48 a.m., Kevin Duling wrote: > >

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

20 times by hand locally without failure: `./gradlew geode-assembly:integrationTest -DintegrationTest.single=RestSecurityIntegrationTest` Thanks, Kevin Duling

Review Request 57431: GEODE-2633: When turning on fine logging, GEODE logs the keystore password in clear text

/apache/geode/internal/util/ArgumentRedactor.java 419f3f976159e601c95a2042bafd96cc9fe9465f Diff: https://reviews.apache.org/r/57431/diff/1/ Testing --- precheckin running Thanks, Kevin Duling

Re: Review Request 57431: GEODE-2633: When turning on fine logging, GEODE logs the keystore password in clear text

tically generated e-mail. To reply, visit: https://reviews.apache.org/r/57431/#review168333 ------- On March 8, 2017, 12:58 p.m., Kevin Duling wrote: > > --- > This is an automatically generate

Re: Review Request 57431: GEODE-2633: When turning on fine logging, GEODE logs the keystore password in clear text

l, and have > > gfsh connect to it using username and password, and see if any of the > > password show up in the logs. > > Kevin Duling wrote: > `ArgumentRedactorJUnitTest` already has 85% method coverage and 95% line > coverage of `ArgumentRedactor`. `SocketCre

Re: A force push happened to geode-native develop!?!

+1. Don't turn to the dark side of the --force. On Mar 8, 2017 3:12 PM, "Dan Smith" wrote: > Yeah, shared branches was kinda of a vague term. I am talking about > develop, master, and release*. > > I think in general if you are working on a feature branch with along other > people, you also shou

Upgrading Jetty

I've been working on GEODE-2539 to upgrade Jetty to the latest version. But I've run in to some snags. The last version that appears to work with Geode without any changes is 9.3.11. In 9.3.12, they made a change to add cookies rather than replace, so some of our tests failed due to two JSESSION

Re: Review Request 57439: GEODE-2576: delete the zip file on locator after it's being streamed to client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57439/#review168794 --- Ship it! Ship It! - Kevin Duling On March 8, 2017, 4:44 p.m

Re: Review Request 57431: GEODE-2633: When turning on fine logging, GEODE logs the keystore password in clear text

742e7f3e93e595844675d0789b995e4ceb4431ac geode-core/src/main/java/org/apache/geode/internal/util/ArgumentRedactor.java 419f3f976159e601c95a2042bafd96cc9fe9465f Diff: https://reviews.apache.org/r/57431/diff/1/ Testing (updated) --- precheckin completed Thanks, Kevin Duling

Re: Review Request 57431: GEODE-2633: When turning on fine logging, GEODE logs the keystore password in clear text

l, and have > > gfsh connect to it using username and password, and see if any of the > > password show up in the logs. > > Kevin Duling wrote: > `ArgumentRedactorJUnitTest` already has 85% method coverage and 95% line > coverage of `ArgumentRedactor`. `SocketCre

Re: Review Request 57522: check for string "null" in server/locator status message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57522/#review168841 --- Ship it! Ship It! - Kevin Duling On March 13, 2017, 3:31

Re: Review Request 57569: GEODE-2645: rewrite test to fix flakiness and improve readability

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57569/#review168842 --- Ship it! Ship It! - Kevin Duling On March 13, 2017, 3:32

Re: Review Request 57611: GEODE-2641: minor help string changes

#comment241196> "using an http connection. Otherwise, logs will be written geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties Lines 1497 (patched) <https://reviews.apache.org/r/57611/#comment241198> no longer use

Re: Review Request 57658: GEODE-2670: fixing pulse authentication/authorization issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57658/#review169041 --- Ship it! Ship It! - Kevin Duling On March 15, 2017, 11:43

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review169085 --- Ship it! Ship It! - Kevin Duling On March 15, 2017, 1:02

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169505 --- Ship it! Ship It! - Kevin Duling On March 17, 2017, 11:48

Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

878bc680bbcc4369eb2d3859c6377b8942bc89d7 Diff: https://reviews.apache.org/r/57796/diff/1/ Testing --- precheckin running Thanks, Kevin Duling

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

/src/main/resources/pulse.properties 878bc680bbcc4369eb2d3859c6377b8942bc89d7 Diff: https://reviews.apache.org/r/57796/diff/1/ Testing (updated) --- precheckin successful Thanks, Kevin Duling

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169587 --- On March 21, 2017, 9:35 a.m., Kevin Duling wrote: > > ---

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

; I would hope we shouldn't need to manully set this in the test. > > Kevin Duling wrote: > I was hoping not, also, but couldn't find another way to handle this. > None of the parameters we are interested in are set in the system properties. > For example `jmx-man

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

; I would hope we shouldn't need to manully set this in the test. > > Kevin Duling wrote: > I was hoping not, also, but couldn't find another way to handle this. > None of the parameters we are interested in are set in the system properties. > For example `jmx-man

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

: https://reviews.apache.org/r/57796/diff/2/ Changes: https://reviews.apache.org/r/57796/diff/1-2/ Testing --- precheckin successful Thanks, Kevin Duling

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

://reviews.apache.org/r/57796/diff/2/ Testing (updated) --- precheckin restarted Thanks, Kevin Duling

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

ed e-mail. To reply, visit: > https://reviews.apache.org/r/57822/ > --- > > (Updated March 21, 2017, 3:05 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, > Kirk Lund, and Swapnil Bawaskar.

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

g at all. > > Let's not introduce this test compile dependency. > > Kevin Duling wrote: > I am also introducing this in GEODE-2671 in order to get ahold of the > `jmx-manager-port` constant. Wait...that should be compile, not testCompile. - Kevin -

Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

.java d7f119b711c3b6168d826d195c582f655f10af68 geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/StringUtils.java df7c5a5e5dde97fd726b46f7007121e0538bd01a Diff: https://reviews.apache.org/r/57823/diff/1/ Testing --- precheckin running Thanks, Kevin Duling

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

: https://reviews.apache.org/r/57796/diff/3/ Changes: https://reviews.apache.org/r/57796/diff/2-3/ Testing --- precheckin restarted Thanks, Kevin Duling

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

Is this system proeprty set manually or by the locator/server when > > starting up the pulse service? > > Kevin Duling wrote: > It is set manually by the test. Prior to my change, Pulse only read from > `pulse.properties` off of the classpath to set the `pulse.port` value

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

On March 21, 2017, 3:05 p.m., Patrick Rhomberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57822/ > ---

Re: Review Request 57611: GEODE-2641: minor help string changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57611/#review169791 --- Ship it! Ship It! - Kevin Duling On March 14, 2017, 10:30

Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57820/#review169900 --- Ship it! Ship It! - Kevin Duling On March 23, 2017, 7:53

Re: Uploading review requests through RBT

Do you have your settings set in your .git/config ? [reviewboard] url = https://reviews.apache.org/ On Wed, Mar 29, 2017 at 4:06 PM, Jared Stewart wrote: > I’m trying to post a review request on Review Board (previously I have > just used GitHub PRs), but this command hangs: > > rbt post --r

PartitionedRegionLoadModelJUnitTest > testRedundancySatisfactionPreferRemoteIp FAILED

I'm receiving the following assertion error when compiling: org.apache.geode.internal.cache.partitioned.PartitionedRegionLoadModelJUnitTest > testRedundancySatisfactionPreferRemoteIp FAILED java.lang.AssertionError: expected:<[Create[member=10. 64.251.218(1639):3,bucketId=0], Create[member=10

Re: Someone to pull in #288

Needs to be #290. I closed 288 in an attempt to have it merge cleaner. What should happen: SimpleSecurityManager -> moved to ./geode-core/src/test/java/org/apache/geode/security/SimpleTestSecurityManager.java SampleSecurityManager -> moved to ./geode-core/src/test/java/org/apache/geode/security/

Re: Review Request 54210: GEODE-2146: deploy should require more elevated privileges than just data:manage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54210/#review157629 --- Ship it! Ship It! - Kevin Duling On Nov. 30, 2016, 1:27 p.m

Re: Review Request 54499: GEODE-2092 Update docs with security examples location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54499/#review158412 --- Ship it! Ship It! - Kevin Duling On Dec. 7, 2016, 12:59 p.m

Re: PartitionedRegionLoadModelJUnitTest > testRedundancySatisfactionPreferRemoteIp FAILED

No, I don't run with a DNS here. On Fri, Nov 18, 2016 at 1:17 PM, Anthony Baker wrote: > On your home network is kduling-mbpro a valid hostname? > > Anthony > > > On Nov 18, 2016, at 1:00 PM, Kevin Duling wrote: > > > > I'm receiving the

Re: Review Request 54605: GEODE-2202: make ServiceState serializable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54605/#review158701 --- Ship it! Ship It! - Kevin Duling On Dec. 9, 2016, 10:36 a.m

Re: Review Request 54608: GEODE-2201 Make UITests a bit more resilient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54608/#review158730 --- Ship it! Ship It! - Kevin Duling On Dec. 9, 2016, 1:50 p.m

Re: Review Request 54617: GEODE-2196: add more tests to cover import cluster-configuration and deploy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54617/#review159014 --- Ship it! Ship It! - Kevin Duling On Dec. 12, 2016, 12:13

Re: Review Request 54772: GEODE-2212: request headers are case-insensitive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54772/#review159330 --- Ship it! Ship It! - Kevin Duling On Dec. 14, 2016, 9:44 p.m

Re: Review Request 54801: GEODE-2207 GEODE-1662: fix and rename SecurityManager callback test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54801/#review159626 --- Ship it! Ship It! - Kevin Duling On Dec. 16, 2016, 2:11 p.m

The right way to remove a region's cache listener?

I'm looking at GEODE-2236 and protecting against the NPE is trivial. But the question is, what is the right way to do this? What is the syntax people would expect to use? What if there are multiple listeners and you wanted to delete one or more

Re: Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/#review159773 --- Ship it! Ship It! - Kevin Duling On Dec. 20, 2016, 2:46 p.m

Re: Review Request 54918: GEODE-2099: The GfshConnectorRule has been refactored to use awaitility to wait and retry till connection is ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54918/#review159775 --- Ship it! Ship It! - Kevin Duling On Dec. 20, 2016, 2:57 p.m

Re: Review Request 54924: GEODE-2238: Fix how peers discover locators with cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54924/#review159836 --- Ship it! Ship It! - Kevin Duling On Dec. 20, 2016, 5:42 p.m

Re: Nightly build takes too long

+1 Twelve hours is a long time. On Fri, Dec 23, 2016 at 11:55 AM, Kirk Lund wrote: > Nevermind. This one failed due to a BindException. > > It's still probably a good idea to break up the nightly build since it's > taking over 12 hours. > > -Kirk > > > On Fri, Dec 23, 2016 at 11:51 AM, Kirk Lun

Re: The right way to remove a region's cache listener?

be removed. On Tue, Dec 20, 2016 at 2:11 PM, Kevin Duling wrote: > I'm looking at GEODE-2236 > <https://issues.apache.org/jira/browse/GEODE-2236> and protecting against > the NPE is trivial. But the question is, what is the right way to do > this? What is the synta

Re: The right way to remove a region's cache listener?

> > > > > > Create the region with two cache listeners: > > > > $ create region --name=data > > > > --cache-listener="my.package.ListenerTypeA,my.package.ListenerTypeB" > > > > > > > > Change my mind and decide to re

Re: The right way to remove a region's cache listener?

er's dir. > > On Tue, Jan 3, 2017 at 2:51 PM, Kevin Duling wrote: > > > I must have some syntax wrong, because I'm not able to add a cache > listener > > from the gfsh command line out of the jar I deployed. > > > > ListenerTypeA and ListenerTypeB exist i

Re: Review Request 55288: GEODE-2261: do not use remote function calls to update the shared configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55288/#review161077 --- Ship it! Ship It! - Kevin Duling On Jan. 9, 2017, 9:36 a.m

Re: Review Request 55356: GEODE-209: delete broken test and fix ProcessStreamReader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55356/#review161079 --- Ship it! Ship It! - Kevin Duling On Jan. 9, 2017, 12:58 p.m

Re: Apache Geode JIRA maintenance

That happened yesterday, too. On Thu, Jan 12, 2017 at 11:55 AM, Joey McAllister wrote: > FYI: > > "update: issues.a.o is currently rebuilding Jira indexes and will be > unavailable until it's completed. ETA is 4 hours" > 10:27 AM PT - 11 Jan 2017 > https://twitter.com/infrabot/status/81924928361

Deploying jars and the class loader

I have been looking in to the behavior of loading classes that have been deployed. When the jar is deployed, the server blindly loads the classes, searching for Geode Functions. Specifically, walks over the classes in the jar, loads each one, and checks to see if both Function and Declarable are

Re: Review Request 55512: GEODE-2296: remove security check in GetFunctionAttribute command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55512/#review161556 --- Ship it! Ship It! - Kevin Duling On Jan. 13, 2017, 10:03

Re: Deploying jars and the class loader

. But I wasn't filtering, I was still loading in all the classes in the jars. On Thu, Jan 12, 2017 at 1:44 PM, Kevin Duling wrote: > I have been looking in to the behavior of loading classes that have been > deployed. When the jar is deployed, the server blindly loads the classes,

Re: Debugging JUnit / DUnit tests

These are my notes which Jinmei started me off with: *Debug GFSH* *==* export JAVA_ARGS=-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=3 *Debug a DUNIT test* = -Ddunit.debug.basePort=2 -Ddunit.debug.suspendVM=1 (-1 means locator, 0-3 means one

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

a try/finally block? Some are and some are not. - Kevin Duling On Jan. 13, 2017, 7:52 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 55687: GEODE-2199: be able to deploy jars without running servers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55687/#review162317 --- Ship it! Ship It! - Kevin Duling On Jan. 18, 2017, 5:35 p.m

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/#review162318 --- Ship it! Ship It! - Kevin Duling On Jan. 17, 2017, 3:27 p.m

Re: Review Request 55603: GEODE-2261: fix the dunit test in nightly build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55603/#review162320 --- Ship it! Ship It! - Kevin Duling On Jan. 16, 2017, 9:03 p.m

Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55890/#review162976 --- Ship it! Ship It! - Kevin Duling On Jan. 24, 2017, 12:55

Re: Review Request 55965: GEODE-1930: fix exception messages in DUnitLauncher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55965/#review163059 --- Ship it! Ship It! - Kevin Duling On Jan. 25, 2017, 3:58 p.m

Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2169cb28cd80d675764ff185ca1ff7c6dbc2b525 Diff: https://reviews.apache.org/r/55781/diff/ Testing --- precheckin successful Thanks, Kevin Duling

  1   2   3   >