----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56396/#review164535 -----------------------------------------------------------
Ship it! My only comment is that I like to see @Before and @After near the top of the class. From the diffs, it looks like SecurityClusterConfigDUnitTest has an @After at the very end. - Kevin Duling On Feb. 7, 2017, 9:28 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56396/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 9:28 a.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > * Refactor GfshShellConnectorRule so that it's easier to use it either as a > rule or classRule > * Refactor LocatorServerStartupRule so that tests using it do not need to > extend from Junit4DUnitTest and can be used as a class rule. > * add NetstatDUnitTest > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java > 28d50da61669746145c143d33947da6b8564ca9d > > geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java > 9d678e1a8bd419e66e9dd79e8f7db5dbeeb0890b > > geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java > 3a3c74cd9d10b617a12c38c1fdd500ebe83a5707 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java > 79f0128ecb87b7e1334f35cb4c0c703cd07af544 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java > f362d4c679d391b50b9ce297d8e31ba9887024e1 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java > f68015e5e4f70c91e3329a53134562b128745fd7 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java > 388fd9d40ccae21d58ea966e4c9c9fd71c46e873 > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java > ac3d1dee3a76e2fa884f826291f88ccbd05d10fa > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java > dbbe0dbc5dd04e06e4876ebcb15ece1cb018d56d > > geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java > fe37f9e2becb46c448a97fa2ac4ed7a9548ff4f9 > > geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java > a7752aeb90da46071aa1ded17ef32c36f8b6208b > > geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java > 66c5be6de9c33226f3ad4d93e9c16dcfbe674c1e > > geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java > ca209a73b247cd422b93864e7de841620140f996 > > geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java > 72654cb868f8a62212825eba72aa4fdf8bc7e39e > > geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java > 24d0db5c123c221b9cff59ef7d91b3d6d2d9b3eb > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 49c141413909b1b31e9d148576832bbf788878eb > geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locator.java > 0350ffd06d09dfa742033baf0fb1c2afff1ee158 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > ac9221cab6ec9a56f269ac90f881049e0ef770de > geode-core/src/test/java/org/apache/geode/test/dunit/rules/Member.java > 129fe681c918a15f0927846fb19c469a0ac683a7 > geode-core/src/test/java/org/apache/geode/test/dunit/rules/Server.java > bc4c5d614caa0d1555e84fc483af3fa74f9e52ef > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java > 0b0e936652444f0171e37fa52653f5a4e9a63c87 > > Diff: https://reviews.apache.org/r/56396/diff/ > > > Testing > ------- > > precheckin pending > > > Thanks, > > Jinmei Liao > >
