----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55356/#review161079 -----------------------------------------------------------
Ship it! Ship It! - Kevin Duling On Jan. 9, 2017, 12:58 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55356/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 12:58 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling. > > > Bugs: GEODE-209 > https://issues.apache.org/jira/browse/GEODE-209 > > > Repository: geode > > > Description > ------- > > Delete FailWithTimeoutOfWaitForOutputToMatchJUnitTest. Test is broken and > doesn't really provide much value. > > Fix ProcessStreamReader. Stream can be closed by either reading thread > calling close or the junit thread invoking destroy in tearDown. If the > reading thread is still running in the background during tearDown (which is > very possible) then the test will fail with GEODE-209 which wasn't the > intention. > > I added a getter to ProcessStreamReader in case a new test wants to check how > the stream was closed but it's unused right now. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/test/golden/FailWithTimeoutOfWaitForOutputToMatchJUnitTest.java > eff4234 > > geode-core/src/test/java/org/apache/geode/test/process/ProcessStreamReader.java > 7f5c2e2 > > Diff: https://reviews.apache.org/r/55356/diff/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
